⚠️ Fakeclient: Only set TypeMeta for unstructured #2633
Merged
+228
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
alvaroaleman
force-pushed
the
pointer
branch
2 times, most recently
from
1929682
to
6c89920
Compare
sbueringer
reviewed
Jan 4, 2024
Currently, the fakeclient unconditionally sets metadata for all objects retrieved through it. This causes two problems: * It differs from the behavior of the real client, except for the cached one if `DeepCopy` is enabled and might lead ppl to think that they can rely on `TypeMeta` being populated, which is absolutely not the case * It causes panics for types that have `TypeMeta` defined as pointer, making it impossible to use the client with them This PR changes the behavior to only populate TypeMeta for `unstructured`.
|
Thx! /lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
ksimon1
added a commit
to ksimon1/ssp-operator
that referenced
this pull request
Jan 19, 2024
there was change in behaviour of kubernetes-sigs/controller-runtime - kubernetes-sigs/controller-runtime#2633. This commit updates test to copy TypeMeta in update CreateOrUpdate function. Signed-off-by: Karel Simon <ksimon@redhat.com>
ksimon1
added a commit
to ksimon1/ssp-operator
that referenced
this pull request
Jan 24, 2024
there was change in behaviour of kubernetes-sigs/controller-runtime - kubernetes-sigs/controller-runtime#2633. This commit updates test to copy TypeMeta in update CreateOrUpdate function. Signed-off-by: Karel Simon <ksimon@redhat.com>
1 task
thbkrkr
added a commit
to elastic/cloud-on-k8s
that referenced
this pull request
Jan 30, 2024
…7468) * fix(deps): update module sigs.k8s.io/controller-runtime to v0.17.0 * make generate * Stop relying on GVK being set on SCP object TestReconcileStackConfigPolicy_Reconcile fails because with kubernetes-sigs/controller-runtime#2633 the fakeClient does not set the TypeMeta of the StackConfigPolicy object, so its typeMeta.Kind becomes empty but CanBeOwnedBy depends on it. The behavior change to not populate TypeMeta for regular object is to be aligned with the behavior of the real client, see kubernetes-sigs/cluster-api#9956: - APIReader does not set GVK on regular typed objects - Cached reader does not set GVK on regular typed objects (if disableDeepCopy = false, which is NOT default). We could just set the Kind of the StackConfigPolicy object in the tests but it's better to stop relying on GVK being set on the StackConfigPolicy object. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thibault Richard <thb.krkr@gmail.com>
11 tasks
tiraboschi
added a commit
to tiraboschi/hyperconverged-cluster-operator
that referenced
this pull request
Jan 31, 2024
- Bump controller-runtime to v0.17.0 - Introduce a few minor fixes for new fakeclient behaviour, see: kubernetes-sigs/controller-runtime#2633 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot
pushed a commit
to kubevirt/hyperconverged-cluster-operator
that referenced
this pull request
Feb 1, 2024
- Bump controller-runtime to v0.17.0 - Introduce a few minor fixes for new fakeclient behaviour, see: kubernetes-sigs/controller-runtime#2633 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
This was referenced Feb 9, 2024
1 task
This was referenced Mar 27, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the fakeclient unconditionally sets metadata for all objects retrieved through it. This causes two problems:
DeepCopyis enabled and might lead ppl to think that they can rely onTypeMetabeing populated, which is absolutely not the caseTypeMetadefined as pointer, making it impossible to use the client with themThis PR changes the behavior to only populate TypeMeta for
unstructured.