Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump the production-dependencies group with 12 updates #847

Merged
merged 2 commits into from Jan 24, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jan 19, 2024

What this PR does / why we need it:
Replaces #846
Fixes code after dependency update - there was change in behaviour of kubernetes-sigs/controller-runtime -
kubernetes-sigs/controller-runtime#2633.
This commit updates test to copy TypeMeta in update CreateOrUpdate
function.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 19, 2024
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 19, 2024

/retest

k8s.io/utils v0.0.0-20231127182322-b307cd553661
kubevirt.io/api v1.1.1
kubevirt.io/containerized-data-importer-api v1.58.0
kubevirt.io/controller-lifecycle-operator-sdk/api v0.2.4
kubevirt.io/qe-tools v0.1.8
kubevirt.io/ssp-operator/api v0.0.0
sigs.k8s.io/controller-runtime v0.16.3
sigs.k8s.io/controller-runtime v0.17.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksimon1 ksimon1 force-pushed the bump-deps branch 3 times, most recently from 82f74f4 to fdbd980 Compare January 23, 2024 12:45
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 24, 2024

/hold depends on #854

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
Bumps the production-dependencies group with 12 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) | `2.14.0` | `2.15.0` |
| [github.com/onsi/gomega](https://github.com/onsi/gomega) | `1.30.0` | `1.31.0` |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.29.0` | `0.29.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.29.0` | `0.29.1` |
| [k8s.io/kube-aggregator](https://github.com/kubernetes/kube-aggregator) | `0.29.0` | `0.29.1` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.16.3` | `0.17.0` |
| [github.com/evanphx/json-patch](https://github.com/evanphx/json-patch) | `5.8.0+incompatible` | `5.8.1+incompatible` |
| [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) | `5.8.0` | `5.8.1` |
| [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) | `0.17.0` | `0.18.0` |
| [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.156.0` | `0.157.0` |
| gopkg.in/evanphx/json-patch.v5 | `5.8.0` | `5.8.1` |
| [k8s.io/klog/v2](https://github.com/kubernetes/klog) | `2.120.0` | `2.120.1` |

Updates `github.com/onsi/ginkgo/v2` from 2.14.0 to 2.15.0
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.14.0...v2.15.0)

Updates `github.com/onsi/gomega` from 1.30.0 to 1.31.0
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.30.0...v1.31.0)

Updates `k8s.io/api` from 0.29.0 to 0.29.1
- [Commits](kubernetes/api@v0.29.0...v0.29.1)

Updates `k8s.io/apiextensions-apiserver` from 0.29.0 to 0.29.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.29.0...v0.29.1)

Updates `k8s.io/kube-aggregator` from 0.29.0 to 0.29.1
- [Commits](kubernetes/kube-aggregator@v0.29.0...v0.29.1)

Updates `sigs.k8s.io/controller-runtime` from 0.16.3 to 0.17.0
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.16.3...v0.17.0)

Updates `github.com/evanphx/json-patch` from 5.8.0+incompatible to 5.8.1+incompatible
- [Release notes](https://github.com/evanphx/json-patch/releases)
- [Commits](evanphx/json-patch@v5.8.0...v5.8.1)

Updates `github.com/evanphx/json-patch/v5` from 5.8.0 to 5.8.1
- [Release notes](https://github.com/evanphx/json-patch/releases)
- [Commits](evanphx/json-patch@v5.8.0...v5.8.1)

Updates `github.com/google/go-containerregistry` from 0.17.0 to 0.18.0
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](google/go-containerregistry@v0.17.0...v0.18.0)

Updates `google.golang.org/api` from 0.156.0 to 0.157.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.156.0...v0.157.0)

Updates `gopkg.in/evanphx/json-patch.v5` from 5.8.0 to 5.8.1

Updates `k8s.io/klog/v2` from 2.120.0 to 2.120.1
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.120.0...v2.120.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: k8s.io/kube-aggregator
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: github.com/evanphx/json-patch
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: github.com/evanphx/json-patch/v5
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: github.com/google/go-containerregistry
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: google.golang.org/api
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: gopkg.in/evanphx/json-patch.v5
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
- dependency-name: k8s.io/klog/v2
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
there was change in behaviour of kubernetes-sigs/controller-runtime -
kubernetes-sigs/controller-runtime#2633.
This commit updates test to copy TypeMeta in update CreateOrUpdate
function.
Signed-off-by: Karel Simon <ksimon@redhat.com>
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ksimon1
Copy link
Member Author

ksimon1 commented Jan 24, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@kubevirt-bot kubevirt-bot merged commit 52dbbcb into kubevirt:main Jan 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants