Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CAPI to v1.7.0-rc.1 #4646

Closed

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Mar 13, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.7.0-rc.1 and all that entails. This PR is for testing and isn't intended to be merged yet. We will refresh it when CAPI v1.7.0 is released.

Which issue(s) this PR fixes:

Fixes #4647

Special notes for your reviewer:

See the migration guide for more information.

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.7.0-rc.1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 13, 2024
main.go Outdated Show resolved Hide resolved
@mboersma

This comment was marked as resolved.

@mboersma mboersma added this to the v1.15 milestone Mar 14, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@mboersma
Copy link
Contributor Author

/retitle [WIP] Bump CAPI to v1.7.0-beta.1

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Bump CAPI to v1.7.0-beta.0 [WIP] Bump CAPI to v1.7.0-beta.1 Mar 26, 2024
@mboersma

This comment was marked as resolved.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.47%. Comparing base (fdb91f9) to head (069f821).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4646   +/-   ##
=======================================
  Coverage   62.47%   62.47%           
=======================================
  Files         195      195           
  Lines       15624    15624           
=======================================
  Hits         9761     9761           
  Misses       5178     5178           
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

mboersma commented Mar 27, 2024

The e2e tests are failing when trying to do clusterctl init. See kubernetes-sigs/cluster-api#10332.

Edit: I'd forgotten to add a 1.7 stanza to the test metadata file apparently. 🤦🏻

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 27, 2024
@mboersma
Copy link
Contributor Author

/retitle Bump CAPI to v1.7.0-beta.1
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot changed the title [WIP] Bump CAPI to v1.7.0-beta.1 Bump CAPI to v1.7.0-beta.1 Mar 27, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance
/test pull-cluster-api-provider-azure-e2e-workload-upgrade
/test pull-cluster-api-provider-azure-windows-custom-builds

@mboersma
Copy link
Contributor Author

Rebased after #4529 merged.

@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

mboersma commented Apr 2, 2024

/retitle Bump CAPI to v1.7.0-rc.0

@k8s-ci-robot k8s-ci-robot changed the title Bump CAPI to v1.7.0-beta.1 Bump CAPI to v1.7.0-rc.0 Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 3, 2024

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-workload-upgrade 8502354 link false /test pull-cluster-api-provider-azure-e2e-workload-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor Author

mboersma commented Apr 4, 2024

/retest

The AKS test specs pass for me when I run e2e locally. ❓

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 15, 2024
@mboersma
Copy link
Contributor Author

/retitle Bump CAPI to v1.7.0-rc.1

@k8s-ci-robot k8s-ci-robot changed the title Bump CAPI to v1.7.0-rc.0 Bump CAPI to v1.7.0-rc.1 Apr 15, 2024
@mboersma
Copy link
Contributor Author

/close

See #4740

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

See #4740

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CAPI v1.7.0-beta.0 has been released and is ready for testing
2 participants