Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/controller-runtime to v0.17.5 #4921

Merged

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented May 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR updates the controller-runtime version.

Which issue(s) this PR fixes:
part of #4907

Special notes for your reviewer:
Due to these two breaking changes in the controller-runtime:

  1. Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache (⚠️ Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache kubernetes-sigs/controller-runtime#2611)
  2. Fake client: Only set TypeMeta for unstructured (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633),

I replace the NewDiscoveryRESTMapper with NewDynamicRESTMapper in membercluster_client.go, and remove TypeMeta check in some of the tests.

Does this PR introduce a user-facing change?:
NONE

Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 9, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.12%. Comparing base (81b8c4c) to head (409c1c7).

Files Patch % Lines
pkg/util/membercluster_client.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4921      +/-   ##
==========================================
- Coverage   53.12%   53.12%   -0.01%     
==========================================
  Files         251      251              
  Lines       20415    20415              
==========================================
- Hits        10846    10845       -1     
- Misses       8855     8856       +1     
  Partials      714      714              
Flag Coverage Δ
unittests 53.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks! So quick!

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@karmada-bot karmada-bot merged commit 3fc8ef5 into karmada-io:master May 9, 2024
12 checks passed
@seanlaii seanlaii deleted the pr_bump_controller_runtime_175 branch May 9, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants