Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Fakeclient: Only set TypeMeta for unstructured #2633

Merged
merged 1 commit into from Jan 4, 2024

Commits on Jan 4, 2024

  1. ⚠️ Fakeclient: Only set TypeMeta for unstructured

    Currently, the fakeclient unconditionally sets metadata for all objects
    retrieved through it. This causes two problems:
    * It differs from the behavior of the real client, except for the cached
      one if `DeepCopy` is enabled and might lead ppl to think that they can
      rely on `TypeMeta` being populated, which is absolutely not the case
    * It causes panics for types that have `TypeMeta` defined as pointer,
      making it impossible to use the client with them
    
    This PR changes the behavior to only populate TypeMeta for `unstructured`.
    alvaroaleman committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f6052ab View commit details
    Browse the repository at this point in the history