Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade k8s.io/* to v0.29.2, sigs.k8s.io/controller-runtime to v0.17.2 #9174

Merged
merged 15 commits into from Mar 4, 2024
Merged

Upgrade k8s.io/* to v0.29.2, sigs.k8s.io/controller-runtime to v0.17.2 #9174

merged 15 commits into from Mar 4, 2024

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Feb 16, 2024 •
edited

How to categorize this PR?

/area open-source dev-productivity
/kind enhancement

What this PR does / why we need it:
Upgrade k8s.io/* to v0.29.2, sigs.k8s.io/controller-runtime to v0.17.2

Notable changes:

Which issue(s) this PR fixes:
Part of #9047

Special notes for your reviewer:
/hold
In draft until #8989 is merged.

Release note:

The following dependencies are updated:
- `k8s.io/*` : `v0.28.4` -> `v0.29.2`
- `sigs.k8s.io/controller-runtime`: `v0.16.3` -> `v0.17.2`

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2024
@rfranzke rfranzke mentioned this pull request Feb 16, 2024
Closed
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2024
@shafeeqes shafeeqes force-pushed the enh/k8s-1.29 branch 3 times, most recently from a3fbe77 to 155ecf3 Compare February 19, 2024 09:26
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2024
This was referenced Feb 26, 2024
Closed
Closed
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@shafeeqes shafeeqes marked this pull request as ready for review February 27, 2024 14:52
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@shafeeqes
Copy link
Contributor Author

/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@shafeeqes
Copy link
Contributor Author

Updating kube-openapi to 582cce7 since the latest HEAD contains lot of breaking changes, will update it separately

@rfranzke
Copy link
Member

/assign

@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 28, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2024
@shafeeqes
Copy link
Contributor Author

/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@rfranzke
Copy link
Member

rfranzke commented Mar 4, 2024

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 4, 2024

LGTM label has been added.

Git tree hash: f67b1daf8a39fba25b183e1f0eb6cd3f4c92adc3

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@gardener-prow gardener-prow bot merged commit ceb8906 into gardener:master Mar 4, 2024
17 checks passed
@shafeeqes shafeeqes changed the title Upgrade k8s.io/* to v0.29.2, sigs.k8s.io/controller-runtime to v0.17.1 Upgrade k8s.io/* to v0.29.2, sigs.k8s.io/controller-runtime to v0.17.2 Mar 4, 2024
@acumino acumino deleted the enh/k8s-1.29 branch March 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shafeeqes @rfranzke