Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module sigs.k8s.io/controller-runtime to v0.17.0 #7468

Merged
merged 5 commits into from Jan 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 16, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sigs.k8s.io/controller-runtime v0.16.3 -> v0.17.0 age adoption passing confidence

Release Notes

kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)

v0.17.0

Compare Source

⚠️ Breaking Changes

  • Fake client: Only set TypeMeta for unstructured (#​2633)
  • Update k8s.io/* deps to 1.29 (#​2457 #​2500 #​2553 #​2588 #​2612 #​2615 #​2621)
  • Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache (#​2611)
  • RESTMapper: don't treat non-existing GroupVersions as errors (#​2571)
  • Webhooks: Deprecate admission.Validator and admission.Defaulter (#​2639)
  • Webhooks: Limit size of AdmissionRequests to 7MB and size of TokenReviews to 1MB (#​2598)

✨ New Features

  • Cache: Allow defining options that apply to all namespaces without explicit config (#​2528)
  • Cache: Allow to remove informers (#​2285)
  • Cache: Add option to set WatchErrorHandler on informers (#​2494)
  • Client: client.MatchingFields now supports multiple indexes (#​2512)
  • Fake client: Add flowcontrol api v1 (#​2623)
  • Reconciler: Add reconcile.ObjectReconciler (#​2592)

🐛 Bug Fixes

  • Add corev1, coordinationv1 scheme for leader election when LeaderElection manager option is true (#​2461)
  • Cache: Default namespace only for namespaced object (#​2480)
  • Client: Don't truncate large int64s in MergePatch (#​2650)
  • controllerutil: Add RemoveControllerReference and HasControllerReference func (#​2509 #​2595)
  • controllerutil: Add RemoveOwnerReference func (#​2462)
  • Dependencies: Refactor tests to drop hard otel dependency (#​2460)
  • Envtest: CRDs that aren't convertible should unset spec.conversion (#​2525)
  • Fake client: Correctly identify if patch call was made on status (#​2508)
  • Fake client: Do not update anything but status when using subresource client (#​2479)
  • Fake client: Fix returning object after status update (#​2489)
  • Fake client: Fix status subresource getting updated on Update when it is empty (#​2484)
  • Fake client: Handle unstructured status update with fake client (#​2495)
  • Manager: Fix goroutine leak (#​2527)
  • Manager: Use HTTP client from leaderElectionConfig for leader election recorder provider (#​2464)
  • RESTMapper: Return NoResourceMatchError when appropriate for backwards compatibility. (#​2472)
  • Webhook: Handle http.NoBody (#​2605)

🌱 Others

  • Client: Make client.MatchingLabels faster (#​2529)
  • Envtest: Allow to ignore scheme.Convertible check for CRDs (#​2555)
  • Envtest: Improve process cleanup (#​2560)
  • Metrics: Add 100/1000s buckets for Prometheus workqueue histograms (#​2638)
  • Metrics: Avoid dependency on apiserver/options if metrics/filters are used (#​2645)
  • Replace k8s.io/utils/pointer with k8s.io/utils/ptr (#​2488)
  • Webhooks: Cleanup webhook variable assignment (#​2604)

🌱 Dependencies

📖 Additionally, there have been 5 contributions to our documentation. (#​2497, #​2498, #​2538, #​2599, #​2602, #​2635 #​2647)

Thanks to all our contributors! 😊


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Jan 16, 2024
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from ab387b5 to 1773f08 Compare January 17, 2024 16:54
go.mod Outdated Show resolved Hide resolved
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 1773f08 to e26b8ec Compare January 18, 2024 17:06
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from e26b8ec to 4d3ce12 Compare January 23, 2024 09:45
@renovate renovate bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 4d3ce12 to 7c948c0 Compare January 26, 2024 13:48
@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 26, 2024

@elasticmachine run elasticsearch-ci/docs

Copy link
Contributor Author

renovate bot commented Jan 26, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 29, 2024

TestReconcileStackConfigPolicy_Reconcile fails because with kubernetes-sigs/controller-runtime#2633 the fakeClient does not set the TypeMeta of the StackConfigPolicy object, so its typeMeta.Kind becomes empty but CanBeOwnedBy depends on it.

The behavior change to not populate TypeMeta for regular object is to be aligned with the behavior of the real client, see kubernetes-sigs/cluster-api#9956:

  • APIReader does not set GVK on regular typed objects
  • Cached reader does not set GVK on regular typed objects (if disableDeepCopy = false, which is NOT default).

We could just set the Kind of the StackConfigPolicy object in the tests 5a1c4a8 but I think it's better to
stop relying on GVK being set on the StackConfigPolicy object 2504e27.

@thbkrkr thbkrkr force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch 2 times, most recently from dee2ebb to 54c6dca Compare January 29, 2024 17:07
@thbkrkr thbkrkr force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 54c6dca to 2504e27 Compare January 29, 2024 19:52
@thbkrkr thbkrkr requested review from pebrc and barkbay January 30, 2024 09:01
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 30, 2024

@elasticmachine run elasticsearch-ci/docs

@thbkrkr thbkrkr merged commit 8140e78 into main Jan 30, 2024
6 checks passed
@thbkrkr thbkrkr deleted the renovate/sigs.k8s.io-controller-runtime-0.x branch January 30, 2024 22:37
@thbkrkr thbkrkr added the exclude-from-release-notes Exclude this PR from appearing in the release notes label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-release-notes Exclude this PR from appearing in the release notes >renovate PRs created by or relating to Renovate v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants