Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.52.0 to 1.53.1 #550

Merged
merged 9 commits into from Jun 26, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2023

Bumps rubocop from 1.52.0 to 1.53.1.

Release notes

Sourced from rubocop's releases.

RuboCop 1.53.1

Bug fixes

  • #11974: Fix an error for Style/RedundantCurrentDirectoryInPath when using string interpolation in require_relative. (@​koic)
  • #11981: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using double quote and single quote characters. (@​koic)
  • #11836: Should not offense single-quoted symbol containing double quotes in Lint/SymbolConversion . (@​KessaPassa)

RuboCop 1.53

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@​koic)
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@​koic)
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@​koic)
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@​koic)
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@​koic)
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@​koic)
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@​koic)
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@​koic)
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@​koic)
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@​koic)
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@​ydah)
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@​rwstauner)

Changes

RuboCop 1.52.1

Bug fixes

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.53.1 (2023-06-26)

Bug fixes

  • #11974: Fix an error for Style/RedundantCurrentDirectoryInPath when using string interpolation in require_relative. ([@​koic][])
  • #11981: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using double quote and single quote characters. ([@​koic][])
  • #11836: Should not offense single-quoted symbol containing double quotes in Lint/SymbolConversion . ([@​KessaPassa][])

1.53.0 (2023-06-23)

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. ([@​koic][])
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. ([@​koic][])
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. ([@​koic][])
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. ([@​koic][])
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. ([@​koic][])
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. ([@​koic][])
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. ([@​koic][])
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. ([@​koic][])
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. ([@​koic][])
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. ([@​koic][])
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. ([@​ydah][])
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. ([@​rwstauner][])

Changes

1.52.1 (2023-06-12)

Bug fixes

  • #11944: Fix an incorrect autocorrect for Style/SoleNestedConditional with Style/MethodCallWithArgsParentheses. ([@​koic][])
  • #11930: Fix exception on Lint/InheritException when class definition has non-constant siblings. ([@​rafaelfranca][])
  • #11919: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for. ([@​koic][])
  • #11928: Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation. ([@​koic][])
  • #11915: Fix a false positive for Lint/RedundantSafeNavigation when &. is used for to_s, to_i, to_d, and other coercion methods. ([@​lucthev][])

... (truncated)

Commits
  • c4913f4 Cut 1.53.1
  • 9db2b2e Update Changelog
  • eac0642 [Fix #11981] Fix an incorrect autocorrect for Style/RedundantRegexpArgument
  • 2339e26 Merge pull request #11970 from KessaPassa/feat/symbol-conversion-in-double-quote
  • 8d2c6ae [Fix #11974] Fix an error for Style/RedundantCurrentDirectoryInPath
  • 5a38fe3 Fix PR reference in CHANGELOG.md 1.51.0
  • a263e4e [Fix rubocop#11836] should not offense single-quoted symbol containing double...
  • b3841fb Merge pull request #11976 from koic/add_vscode_rubocop_to_lsp_doc
  • 508269f [Doc] Add vscode-rubocop to the LSP doc
  • 08dbb42 Fix a build error
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.52.0 to 1.53.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.52.0...v1.53.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner June 26, 2023 11:08
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jun 26, 2023
This automated commit dumps the contents of the full RuboCop config.
[dependabot skip]
@larouxn
Copy link
Contributor

larouxn commented Jun 26, 2023

👋 Proposing we enable the new Lint/MixedCaseRange cop re: #548.

@github-actions github-actions bot added the config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops label Jun 26, 2023
@sambostock sambostock force-pushed the dependabot/bundler/rubocop-1.53.1 branch from 14901b2 to a0609aa Compare June 26, 2023 14:19
@sambostock
Copy link
Contributor

sambostock commented Jun 26, 2023

I've enabled all the rules introduced in 1.53.

Lint/MixedCaseRange
Don't /[A-z]/ cause you probably meant /[A-Za-z]/.
Lint/RedundantRegexpQuantifiers
Don't /(?:x+)+/ cause it's redundant.
Style/RedundantCurrentDirectoryInPath
Don't require_relative './...', the ./ is redundant.
Style/RedundantRegexpArgument
Don't pass /.../ when you could pass "...".
Style/ReturnNilInPredicateMethodDefinition
Don't return nil in predicate methods; return false.
Style/YAMLFileRead
Don't YAML.load(File.read(path)) when you can YAML.load_file(path).

🎩'd this in Core, which resulted in ~500 new offenses, with all but one auto-correctable.

@sambostock sambostock merged commit 84ce09e into main Jun 26, 2023
21 checks passed
@sambostock sambostock deleted the dependabot/bundler/rubocop-1.53.1 branch June 26, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants