Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/IdenticalConditionalBranches #11958

Conversation

koic
Copy link
Member

@koic koic commented Jun 16, 2023

This PR fixes the following error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch:

$ cat example.rb
if condition
  ()
else
  foo
end

$ bundle exec rubocop --only Style/IdenticalConditionalBranches -d
(snip)

An error occurred while Style/IdenticalConditionalBranches cop was inspecting
/Users/koic/src/github.com/koic/rubocop-issues/identical_conditional_branches/example.rb:1:0.
undefined method `assignment?' for nil:NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/identical_conditional_branches.rb:161:in `duplicated_expressions?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/identical_conditional_branches.rb:146:in `check_branches'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/identical_conditional_branches.rb:120:in `on_if'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/IdenticalConditionalBranches`
when using empty parentheses in the `if` branch:

```console
$ cat example.rb
if condition
  ()
else
  foo
end

$ bundle exec rubocop --only Style/IdenticalConditionalBranches -d
(snip)

An error occurred while Style/IdenticalConditionalBranches cop was inspecting
/Users/koic/src/github.com/koic/rubocop-issues/identical_conditional_branches/example.rb:1:0.
undefined method `assignment?' for nil:NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/identical_conditional_branches.rb:161:in `duplicated_expressions?'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/identical_conditional_branches.rb:146:in `check_branches'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/identical_conditional_branches.rb:120:in `on_if'
```
@koic koic merged commit 78c55da into rubocop:master Jun 17, 2023
28 checks passed
@koic koic deleted the fix_an_error_for_style_identical_conditional_branches branch June 17, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant