Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Lint/NumberConversion #11946

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 13, 2023

This PR fixes the following error for Lint/NumberConversion when using multiple number conversion methods:

$ cat example.rb
case foo.to_f
when 0.0
bar
else
baz
end.to_i

$ bundle exec rubocop --only Lint/NumberConversion -A -d
(snip)

An error occurred while Lint/NumberConversion cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/number_conversion/example.rb:1:5.
Parser::Source::TreeRewriter detected clobbering
/Users/koic/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/parser-3.2.2.3/lib/parser/source/tree_rewriter.rb:427:in `trigger_policy'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Lint/NumberConversion`
when using multiple number conversion methods:

```console
$ cat example.rb
case foo.to_f
when 0.0
bar
else
baz
end.to_i

$ bundle exec rubocop --only Lint/NumberConversion -A -d
(snip)

An error occurred while Lint/NumberConversion cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/number_conversion/example.rb:1:5.
Parser::Source::TreeRewriter detected clobbering
/Users/koic/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/parser-3.2.2.3/lib/parser/source/tree_rewriter.rb:427:in `trigger_policy'
```
@koic koic force-pushed the fix_an_error_for_lint_number_conversion branch from c1087fc to 9ab4efb Compare June 13, 2023 02:28
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 13, 2023

The conversion looks a big ugly for multi-line forms, but the fix is good overall. Thanks!

@bbatsov bbatsov merged commit c9bc24c into rubocop:master Jun 13, 2023
28 checks passed
@koic koic deleted the fix_an_error_for_lint_number_conversion branch June 13, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants