Enable Lint/MixedCaseRange cop #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automated commit dumps the contents of the full RuboCop config. [dependabot skip]
github-actions
bot
added
the
config change
|
Considering the CI complexities here re: other cops, I'm thinking we should fetch the Dependabot RuboCop 1.52.0 → 1.53.0 bump and simply enable this cop in there along with enabling/disabling the other new cops. Thus, closing this PR. |
|
Enabled in #550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing we enable the new
Lint/MixedCaseRangecop as it should ensure better (correct) regex ranges i.e.[A-Za-z]not[A-z]. The latter contains characters beyond the former.Note, this cop was added in the latest RuboCop release 1.53.0 which just came out last week, hence the temporary bump within this PR. Will rebase this PR once this repo is updated to RuboCop 1.53.0, which should make the changelog simply the
rubocop.ymland configEnabled: false/pending→enabled: true.