Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode-rubocop to the LSP doc #11976

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

koic
Copy link
Member

@koic koic commented Jun 23, 2023

vscode-rubocop has been released:
https://marketplace.visualstudio.com/items?itemName=rubocop.vscode-rubocop

This PR adds vscode-rubocop to the LSP doc.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the add_vscode_rubocop_to_lsp_doc branch 2 times, most recently from 24c0a1f to 5c3df08 Compare June 23, 2023 16:39
vscode-rubocop has been released:
https://marketplace.visualstudio.com/items?itemName=rubocop.vscode-rubocop

This PR adds vscode-rubocop to the LSP doc.
@koic koic force-pushed the add_vscode_rubocop_to_lsp_doc branch from 5c3df08 to 508269f Compare June 23, 2023 16:43
@koic koic merged commit b3841fb into rubocop:master Jun 23, 2023
28 checks passed
@koic koic deleted the add_vscode_rubocop_to_lsp_doc branch June 23, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant