Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation #11928

Conversation

koic
Copy link
Member

@koic koic commented Jun 5, 2023

This PR fixes the following incorrect autocorrect for Lint/AmbiguousBlockAssociation with Style/MethodCallWithArgsParentheses.

expect { foo }.not_to change { bar }

Before

$ bundle exec rubocop --only Lint/AmbiguousBlockAssociation,Style/MethodCallWithArgsParentheses -a
Inspecting 1 file
F

Offenses:

example.rb:1:1: W: [Corrected] Lint/AmbiguousBlockAssociation: Parenthesize the param change { bar } to make sure that the block will be associated with the change method call.
expect { foo }.not_to change { bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
example.rb:1:1: C: [Corrected] Style/MethodCallWithArgsParentheses: Use parentheses for method calls with arguments.
expect { foo }.not_to change { bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
example.rb:1:38: F: Lint/Syntax: unexpected token tRPAREN
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)
expect { foo }.not_to(change { bar }))
                                     ^

1 file inspected, 3 offenses detected, 2 offenses corrected

Syntax error with redundant closing parentheses.

$ git diff .
diff --git a/x/example.rb b/x/example.rb
index 142ff55..6de7188 100644
--- a/x/example.rb
+++ b/x/example.rb
@@ -1 +1 @@
-expect { foo }.not_to change { bar }
+expect { foo }.not_to(change { bar }))

After

Valid syntax.

$ git diff .
diff --git a/x/example.rb b/x/example.rb
index 142ff55..7808ed5 100644
--- a/x/example.rb
+++ b/x/example.rb
@@ -1 +1 @@
-expect { foo }.not_to change { bar }
+expect { foo }.not_to(change { bar })

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_incorrect_autocorrect_for_lint_ambiguous_block_association branch from e64dbdd to 30f7e53 Compare June 5, 2023 05:16
This PR fixes the following incorrect autocorrect for
`Lint/AmbiguousBlockAssociation` with `Style/MethodCallWithArgsParentheses`.

```ruby
expect { foo }.not_to change { bar }
```

## Before

```console
$ bundle exec rubocop --only Lint/AmbiguousBlockAssociation,Style/MethodCallWithArgsParentheses -a
Inspecting 1 file
F

Offenses:

example.rb:1:1: W: [Corrected] Lint/AmbiguousBlockAssociation: Parenthesize the param change { bar } to make sure that the block will be associated with the change method call.
expect { foo }.not_to change { bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
example.rb:1:1: C: [Corrected] Style/MethodCallWithArgsParentheses: Use parentheses for method calls with arguments.
expect { foo }.not_to change { bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
example.rb:1:38: F: Lint/Syntax: unexpected token tRPAREN
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)
expect { foo }.not_to(change { bar }))
                                     ^

1 file inspected, 3 offenses detected, 2 offenses corrected
```

Syntax error with redundant closing parentheses.

```diff
$ git diff .
diff --git a/x/example.rb b/x/example.rb
index 142ff55..6de7188 100644
--- a/x/example.rb
+++ b/x/example.rb
@@ -1 +1 @@
-expect { foo }.not_to change { bar }
+expect { foo }.not_to(change { bar }))
```

## After

Valid syntax.

```diff
$ git diff .
diff --git a/x/example.rb b/x/example.rb
index 142ff55..7808ed5 100644
--- a/x/example.rb
+++ b/x/example.rb
@@ -1 +1 @@
-expect { foo }.not_to change { bar }
+expect { foo }.not_to(change { bar })
```
@koic koic changed the title Fix an incorrect auto-correct for Lint/AmbiguousBlockAssociation Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation Jun 5, 2023
@koic koic force-pushed the fix_incorrect_autocorrect_for_lint_ambiguous_block_association branch from 30f7e53 to 10ec66a Compare June 5, 2023 05:17
@koic koic merged commit a796b10 into rubocop:master Jun 5, 2023
28 checks passed
@koic koic deleted the fix_incorrect_autocorrect_for_lint_ambiguous_block_association branch June 5, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant