Fix handling of escaped octals in duplicate regexp cop #11562
Conversation
| if seen.include?(current_child_source) | ||
| next if start_with_escaped_zero_number?(current_child_source, next_child.to_s) | ||
| def group_expressions(node, expressions) | ||
| expressions = expressions.to_a |
There was a problem hiding this comment.
This code seems unnecessary, right?
| expressions = expressions.to_a |
There was a problem hiding this comment.
i was using the array as a "enum" so i can just remove items until it's empty.
it required less state tracking than the original enumerator.
There was a problem hiding this comment.
part of why i ended up here was because the original method was triggering several linters about method length and complexity, but i couldn't update the counter from a separate method, so in breaking it into smaller methods using a mutable array seemed simplest.
|
|
||
| private | ||
| def pop_octal_digits(current_child, expressions) | ||
| 2.times do |
There was a problem hiding this comment.
It looks better when named with 2 as a constant
lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb
Outdated
Show resolved
Hide resolved
te is the same as ts + length plus te is angering the spell checker
|
As I'm not familiar with the nuances of |
|
@koic Are we good to merge this PR? |
|
Yep! Let's take this change! |
|
Thanks! |
This improves the handling of escaped octals (as long as we allow regexp_parser < 2.7)
for the duplicate regexp character class element cop.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.