Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.50.2 to 1.51.0 #719

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2023

Bumps rubocop from 1.50.2 to 1.51.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.51 (The RubyKaigi 2023 Edition)

New features

Bug fixes

  • #11812: Fix a false negative for Style/Attr when using attr and method definitions. (@​koic)
  • #11861: Fix a false positive for Layout/SpaceAfterSemicolon when no space between a semicolon and a closing brace of string interpolation. (@​koic)
  • #11830: Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler. (@​koic)
  • #11846: Fix a false positive for Lint/RedundantStringCoercion when using to_s(argument) in puts argument. (@​koic)
  • #11865: Fix an error for Naming/ConstantName when assigning a constant from an empty branch of else. (@​koic)
  • #11844: Fix a false positive for Style/RedundantLineContinuation when using line concatenation for assigning a return value and without argument parentheses. (@​koic)
  • #11808: Fix a false positive for Style/RegexpLiteral when using a regexp starts with equal as a method argument. (@​koic)
  • #11822: Fix an error for Layout/SpaceInsideBlockBraces when a method call with a multiline block is used as an argument. (@​koic)
  • #11849: Fix an error for Style/ConditionalAssignment when EnforcedStyle: assign_inside_condition and using empty case condition. (@​koic)
  • #11967: Fix error for Style/IfInsideElse when a deep nested multiline if...then...elsif...else...end. (@​koic)
  • #11842: Fix an error for Style/IfUnlessModifier when using multiple if modifier in the long one line. (@​koic)
  • #11835: Fix an error for Style/RequireOrder when multiple require are not sorted. (@​koic)
  • #11809: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when exception variable is referenced after rescue statement. (@​koic)
  • #11852: Fix an incorrect autocorrect for Style/EvalWithLocation when using eval without line number and with parenthesized method call. (@​koic)
  • #11862: Fix an incorrect autocorrect for Style/GuardClause when using raise in else branch in a one-liner with then. (@​koic)
  • #11868: Fix a false positive for Style/HashExcept when method's receiver/argument is not the same as block key argument. (@​fatkodima)
  • #11858: Fix false positives when using source comments in blocks. (@​reitermarkus)
  • #11510: Fix Lint/UselessAssignment false positive when using numbered block parameters. (@​sambostock)
  • #11872: Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments. (@​Bhacaz)
  • #11820: Fix Lint/EmptyConditionalBody false-positives for commented empty elsif body. (@​r7kamura)

Changes

  • #11859: Add rubocop-factory_bot to suggested extensions. (@​ydah)
  • #10791: (Breaking) Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). (@​koic)
  • #11826: Exclude **/*.jb from Lint/TopLevelReturnWithArgument. (@​r7kamura)
  • #11871: Mark Style/DataInheritance as unsafe autocorrect, Style/OpenStructUse as unsafe, and Security/CompoundHash as unsafe. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.51.0 (2023-05-13)

New features

Bug fixes

  • #11812: Fix a false negative for Style/Attr when using attr and method definitions. ([@​koic][])
  • #11861: Fix a false positive for Layout/SpaceAfterSemicolon when no space between a semicolon and a closing brace of string interpolation. ([@​koic][])
  • #11830: Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler. ([@​koic][])
  • #11846: Fix a false positive for Lint/RedundantStringCoercion when using to_s(argument) in puts argument. ([@​koic][])
  • #11865: Fix an error for Naming/ConstantName when assigning a constant from an empty branch of else. ([@​koic][])
  • #11844: Fix a false positive for Style/RedundantLineContinuation when using line concatenation for assigning a return value and without argument parentheses. ([@​koic][])
  • #11808: Fix a false positive for Style/RegexpLiteral when using a regexp starts with equal as a method argument. ([@​koic][])
  • #11822: Fix an error for Layout/SpaceInsideBlockBraces when a method call with a multiline block is used as an argument. ([@​koic][])
  • #11849: Fix an error for Style/ConditionalAssignment when EnforcedStyle: assign_inside_condition and using empty case condition. ([@​koic][])
  • #11967: Fix error for Style/IfInsideElse when a deep nested multiline if...then...elsif...else...end. ([@​koic][])
  • #11842: Fix an error for Style/IfUnlessModifier when using multiple if modifier in the long one line. ([@​koic][])
  • #11835: Fix an error for Style/RequireOrder when multiple require are not sorted. ([@​koic][])
  • #11809: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when exception variable is referenced after rescue statement. ([@​koic][])
  • #11852: Fix an incorrect autocorrect for Style/EvalWithLocation when using eval without line number and with parenthesized method call. ([@​koic][])
  • #11862: Fix an incorrect autocorrect for Style/GuardClause when using raise in else branch in a one-liner with then. ([@​koic][])
  • #11868: Fix a false positive for Style/HashExcept when method's receiver/argument is not the same as block key argument. ([@​fatkodima][])
  • #11858: Fix false positives when using source comments in blocks. ([@​reitermarkus][])
  • #11510: Fix Lint/UselessAssignment false positive when using numbered block parameters. ([@​sambostock][])
  • #11872: Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments. ([@​Bhacaz][])
  • #11820: Fix Lint/EmptyConditionalBody false-positives for commented empty elsif body. ([@​r7kamura][])

Changes

  • #11859: Add rubocop-factory_bot to suggested extensions. ([@​ydah][])
  • #10791: (Breaking) Drop runtime support for Ruby 2.6 and JRuby 9.3 (CRuby 2.6 compatible). ([@​koic][])
  • #11826: Exclude **/*.jb from Lint/TopLevelReturnWithArgument. ([@​r7kamura][])
  • #11871: Mark Style/DataInheritance as unsafe autocorrect, Style/OpenStructUse as unsafe, and Security/CompoundHash as unsafe. ([@​koic][])
Commits
  • a38991d Cut 1.51 to celebrate RubyKaigi 2023
  • 0d04592 Update Changelog
  • 0970cc1 Fix a false positive for Lint/IncompatibleIoSelectWithFiberScheduler
  • 922501f Add new Style/ExactRegexpMatch cop
  • 7cda5ae Mark some cops as unsafe
  • 824441b Merge pull request #11872 from Bhacaz/fix_development_dependencies_cop_with_a...
  • e768851 Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependen...
  • 7ef8629 Merge pull request #11870 from fatkodima/fix-hash_except-incorrect-arguments
  • 1fdb7d6 Fix a false positive for when method's receiver/argument is not the same as ...
  • de330b3 Fix an error for Style/IfInsideElse
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner May 15, 2023 03:00
@dependabot dependabot bot requested review from st0012 and bitwise-aiden May 15, 2023 03:00
@dependabot dependabot bot added dependencies dependencies ruby labels May 15, 2023
@github-actions github-actions bot enabled auto-merge May 15, 2023 03:01
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.51.0 branch from 6405915 to 5498485 Compare May 15, 2023 03:06
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.51.0 branch from 5498485 to 0c69161 Compare May 15, 2023 03:09
@andyw8
Copy link
Contributor

andyw8 commented May 29, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.51.0 branch from 0c69161 to 541a7ce Compare May 29, 2023 18:04
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.51.0 branch from 541a7ce to 66788f7 Compare May 30, 2023 21:07
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.50.2 to 1.51.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.50.2...v1.51.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@andyw8 andyw8 force-pushed the dependabot/bundler/rubocop-1.51.0 branch from 66788f7 to aa62b67 Compare May 31, 2023 15:55
@andyw8
Copy link
Contributor

andyw8 commented May 31, 2023

Failing due to rubocop/rubocop#11905

@Shopify Shopify deleted a comment from github-actions bot May 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.262993 std_dev: 0.004992
          textDocument/diagnostic average: 0.037932 std_dev: 0.008491
      textDocument/selectionRange average: 0.003207 std_dev: 0.000344
            textDocument/codeLens average: 0.001566 std_dev: 0.000103
        textDocument/documentLink average: 0.001564 std_dev: 0.0001
 textDocument/semanticTokens/full average: 0.001542 std_dev: 0.000259
      textDocument/documentSymbol average: 0.001529 std_dev: 9.2e-05
        textDocument/foldingRange average: 0.001426 std_dev: 8.9e-05
   textDocument/documentHighlight average: 0.001333 std_dev: 0.00011
textDocument/semanticTokens/range average: 0.000729 std_dev: 2.1e-05
               codeAction/resolve average: 0.00056 std_dev: 6.6e-05
               textDocument/hover average: 0.000526 std_dev: 5.8e-05
           textDocument/inlayHint average: 0.00049 std_dev: 4.2e-05
    textDocument/onTypeFormatting average: 9.5e-05 std_dev: 5.1e-05
          textDocument/formatting average: 4.5e-05 std_dev: 2.4e-05
          textDocument/codeAction average: 2.7e-05 std_dev: 2.7e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged

@andyw8
Copy link
Contributor

andyw8 commented Jun 2, 2023

I've bumped to 1.52 but it's still failing.

(comment out the rescue clause of line 90 in lib/ruby_lsp/requests/support/rubocop_runner.rb to see the underlying failure).

@andyw8
Copy link
Contributor

andyw8 commented Jun 2, 2023

SPEC_REPORTER=1 bin/test test/requests/diagnostics_expectations_test.rb for

@andyw8
Copy link
Contributor

andyw8 commented Jun 2, 2023

I've logged an issue with RuboCop: rubocop/rubocop#11919

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 5, 2023

A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@andyw8
Copy link
Contributor

andyw8 commented Jun 5, 2023

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 5, 2023

Superseded by #742.

@dependabot dependabot bot closed this Jun 5, 2023
auto-merge was automatically disabled June 5, 2023 12:23

Pull request was closed

@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.51.0 branch June 5, 2023 12:23
vinistock pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant