Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocorrection for Lint/TopLevelReturnWithArgument #11824

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

r7kamura
Copy link
Contributor

I have added an autocorrection that simply removes the argument part from top-level return.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Apr 29, 2023

I think there is not a fix other than removing arguments, so this logic looks acceptable to me.

Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@r7kamura r7kamura force-pushed the lint-top-level-return-autocorrect branch from af9d4e1 to 52d2d21 Compare April 29, 2023 23:58
@koic koic merged commit 45df9f1 into rubocop:master Apr 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants