Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Style/ExactRegexpMatch cop #11869

Merged
merged 1 commit into from
May 13, 2023

Conversation

koic
Copy link
Member

@koic koic commented May 12, 2023

This PR adds new Style/ExactRegexpMatch cop that checks for exact regexp match inside Regexp literals.

# bad
string =~ /\Astring\z/
string === /\Astring\z/
string.match(/\Astring\z/)
string.match?(/\Astring\z/)

# good
string == 'string'

# bad
string !~ /\Astring\z/

# good
string != 'string'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR adds new `Style/ExactRegexpMatch` cop
that checks for exact regexp match inside Regexp literals.

```ruby
# bad
string =~ /\Astring\z/
string === /\Astring\z/
string.match(/\Astring\z/)
string.match?(/\Astring\z/)

# good
string == 'string'

# bad
string !~ /\Astring\z/

# good
string != 'string'
```
@koic koic force-pushed the add_new_style_exact_regexp_match_cop branch from 3e6f076 to 0eae6c8 Compare May 12, 2023 00:48
@bbatsov bbatsov merged commit 922501f into rubocop:master May 13, 2023
29 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented May 13, 2023

Looks good to me. Thanks!

@koic koic deleted the add_new_style_exact_regexp_match_cop branch May 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants