Fix Gemspec/DevelopmentDependencies not trigger when add_development_…

[Bhacaz]

…dependency has more then one arguments

I was wondering why this cop was not triggered in my gemspec, to finally found that, the node matcher didn't match if an argument (or more) is passed.

# triggered 
spec.add_development_dependency 'foo'

# not triggered
spec.add_development_dependency 'foo', '>= 1.0'

There was a comment in the PR that introduce this cop which had no response and I didn't found any related issues about this behaviour.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[koic]

Suggested change

	it 'registers an offense when using `#add_development_dependency` in a gemspec with version' do
	it 'registers an offense when using `#add_development_dependency` in a gemspec with a single version argument' do

[koic]

Suggested change

	it 'registers an offense when using `#add_development_dependency` in a gemspec with many arguments' do
	it 'registers an offense when using `#add_development_dependency` in a gemspec with two version arguments' do

[koic]

Is there ever a need for more than two arguments for the version? If not, wouldn't the following matcher suffice?

Suggested change

	(send _ :add_development_dependency (str #forbidden_gem? ...) (...)*)
	(send _ :add_development_dependency (str #forbidden_gem? ...) _? _?)

[koic]

Thanks!