Fix a false positive for when method's receiver/argument is not the same as block key argument #11870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
May 12, 2023
lib/rubocop/cop/style/hash_except.rb
Outdated
Comment on lines
99
to
102
| return false if (send_node.method?(:include?) || send_node.method?(:exclude?)) && | ||
| send_node.first_argument&.source != key_arg.source | ||
|
|
||
| true |
There was a problem hiding this comment.
Can you tweak it?
Suggested change
| return false if (send_node.method?(:include?) || send_node.method?(:exclude?)) && | |
| send_node.first_argument&.source != key_arg.source | |
| true | |
| return true if !send_node.method?(:include?) && !send_node.method?(:exclude?) | |
| send_node.first_argument&.source != key_arg.source |
…ame as block key argument
fatkodima
force-pushed
the
fix-hash_except-incorrect-arguments
branch
from
7850f9a
to
1fdb7d6
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11868.
This PR properly checks method's receiver/argument, before considering if this is an offense.