Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/RequireOrder #11835

Merged
merged 1 commit into from
May 2, 2023

Conversation

koic
Copy link
Member

@koic koic commented May 2, 2023

This PR fixes the following error for Style/RequireOrder when multiple require are not sorted:

$ cat example.rb
require 'd'
require 'a'
require 'b'
require 'c'
$ bundle exec rubocop --only Style/RequireOrder -A
Inspecting 1 file
An error occurred while Style/RequireOrder cop was inspecting
/Users/koic/src/github.com/koic/rubocop-issues/require_order/example.rb:4:0.
To see the complete backtrace run rubocop -d.
C

Offenses:

example.rb:2:1: C: [Corrected] Style/RequireOrder: Sort require in alphabetical order.
require 'a'
^^^^^^^^^^^
example.rb:3:1: C: [Corrected] Style/RequireOrder: Sort require in alphabetical order.
require 'b'
^^^^^^^^^^^
example.rb:4:1: C: [Corrected] Style/RequireOrder: Sort require in alphabetical order.
require 'c'
^^^^^^^^^^^

1 file inspected, 3 offenses detected, 3 offenses corrected

1 error occurred:
An error occurred while Style/RequireOrder cop was inspecting
/Users/koic/src/github.com/koic/rubocop-issues/require_order/example.rb:4:0.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop/rubocop/issues

Mention the following information in the issue report:
1.50.2 (using Parser 3.2.2.1, rubocop-ast 1.28.1, running on ruby 3.2.1) [x86_64-darwin19]

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/RequireOrder` when multiple `require` are not sorted:

```console
$ cat example.rb
require 'd'
require 'a'
require 'b'
require 'c'
```

```console
$ bundle exec rubocop --only Style/RequireOrder -A
Inspecting 1 file
An error occurred while Style/RequireOrder cop was inspecting
/Users/koic/src/github.com/koic/rubocop-issues/require_order/example.rb:4:0.
To see the complete backtrace run rubocop -d.
C

Offenses:

example.rb:2:1: C: [Corrected] Style/RequireOrder: Sort require in alphabetical order.
require 'a'
^^^^^^^^^^^
example.rb:3:1: C: [Corrected] Style/RequireOrder: Sort require in alphabetical order.
require 'b'
^^^^^^^^^^^
example.rb:4:1: C: [Corrected] Style/RequireOrder: Sort require in alphabetical order.
require 'c'
^^^^^^^^^^^

1 file inspected, 3 offenses detected, 3 offenses corrected

1 error occurred:
An error occurred while Style/RequireOrder cop was inspecting
/Users/koic/src/github.com/koic/rubocop-issues/require_order/example.rb:4:0.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop/rubocop/issues

Mention the following information in the issue report:
1.50.2 (using Parser 3.2.2.1, rubocop-ast 1.28.1, running on ruby 3.2.1) [x86_64-darwin19]
```
@koic koic force-pushed the fix_an_error_for_style_require_order branch from 03c6a46 to 1e3afe7 Compare May 2, 2023 10:44
@koic koic merged commit efdd3f5 into rubocop:master May 2, 2023
28 checks passed
@koic koic deleted the fix_an_error_for_style_require_order branch May 2, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant