New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearly separate Config and Settings terms used in struct names throughout the codebase #6767
Labels
release:required-for-ga
Must be resolved before GA release
Comments
dmitryax
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 13, 2022
I think we should start working on this, because we cannot delay until the stability. |
This was referenced Jan 25, 2024
This was referenced Jan 26, 2024
2 tasks
dmitryax
pushed a commit
that referenced
this issue
Feb 23, 2024
**Description:** Removes deprecated items from `confighttp` **Link to tracking Issue:** Related to #6767
Removing from the confighttp milestone as the public structs now use |
TylerHelmuth
removed this from the `go.opentelemetry.io/collector/confighttp` 1.0 milestone
Feb 23, 2024
Closing this in favour of #9428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we use the
Config
term for collector configuration as a whole and parts of it defined for receivers/processors/exporters/extensions. Examples:otelcol.Config
component.Config
otlpexporter.Config
But for unmarshalling some deeper parts of the user config, we use
Settings
structs, for example:exporterhelper.QueueSettings
configgrpc.GRPCClientSettings
configtls.TLSSetting
At the same time
service/telemetry
package still usesConfig
, e.g.MetricsConfig
,LogsSamplingConfig
, andTracesConfig
.The suggestion is to use
Config
term for all the structs used to unmarshal any parts of the YAML config provided by users. We will keepSettings
only for structs that are populated programmatically, like:component.TelemetrySettings
component.ReceiverSettings
The text was updated successfully, but these errors were encountered: