[configgrpc] Deprecate GRPCClientSettings, use ClientConfig instead #9402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9402 +/- ##
==========================================
+ Coverage 90.22% 90.42% +0.19%
==========================================
Files 345 344 -1
Lines 18021 18024 +3
==========================================
+ Hits 16260 16298 +38
+ Misses 1433 1396 -37
- Partials 328 330 +2 ☔ View full report in Codecov by Sentry. |
atoulme
force-pushed
the
grpcclientsettings_grpcclientconfig
branch
from
8a7b914
to
fc8694a
Compare
atoulme
force-pushed
the
grpcclientsettings_grpcclientconfig
branch
from
fc8694a
to
b84eace
Compare
dmitryax
approved these changes
Jan 31, 2024
|
Waiting for result of #9403 (comment) |
atoulme
changed the title
|
@atoulme PTAL at the failing linter |
dmitryax
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate GRPCClientSettings, use
GRPCClientConfig insteadLink to tracking Issue:
#6767