-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scraperhelper] Deprecate ScraperControllerSettings, use ControllerConfig instead #9401
[scraperhelper] Deprecate ScraperControllerSettings, use ControllerConfig instead #9401
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9401 +/- ##
==========================================
- Coverage 90.61% 90.60% -0.01%
==========================================
Files 347 347
Lines 18236 18238 +2
==========================================
Hits 16525 16525
- Misses 1381 1383 +2
Partials 330 330 ☔ View full report in Codecov by Sentry. |
Please rebase |
72f22fd
to
cc2b510
Compare
Rebased. One more thing. The signature is:
However, the parameter |
Please |
Done, it's removed. |
8836358
to
04e5c8b
Compare
Description:
Deprecate ScraperControllerSettings, use
ScraperControllerConfig insteadLink to tracking Issue:
#6767