Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scraperhelper] Deprecate ScraperControllerSettings, use ControllerConfig instead #9401

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 26, 2024

Description:
Deprecate ScraperControllerSettings, use ScraperControllerConfig instead

Link to tracking Issue:
#6767

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (59b45a5) 90.61% compared to head (04e5c8b) 90.60%.

Files Patch % Lines
receiver/scraperhelper/config.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9401      +/-   ##
==========================================
- Coverage   90.61%   90.60%   -0.01%     
==========================================
  Files         347      347              
  Lines       18236    18238       +2     
==========================================
  Hits        16525    16525              
- Misses       1381     1383       +2     
  Partials      330      330              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

receiver/scraperhelper/config.go Outdated Show resolved Hide resolved
@atoulme atoulme changed the title [scraperhelper] Deprecate ScraperControllerSettings, use ScraperControllerConfig instead [scraperhelper] Deprecate ScraperControllerSettings, use ControllerConfig instead Feb 1, 2024
@bogdandrutu
Copy link
Member

Please rebase

@atoulme atoulme force-pushed the scrapercontrollersettings_scrapercontrollerconfig branch from 72f22fd to cc2b510 Compare February 5, 2024 19:49
@atoulme
Copy link
Contributor Author

atoulme commented Feb 5, 2024

Rebased. One more thing. The signature is:

func NewDefaultControllerConfig(component.Type) ControllerConfig {

However, the parameter component.Type is not used. Should we remove it?

@bogdandrutu
Copy link
Member

However, the parameter component.Type is not used. Should we remove it?

Please

@atoulme
Copy link
Contributor Author

atoulme commented Feb 5, 2024

Done, it's removed.

@atoulme atoulme force-pushed the scrapercontrollersettings_scrapercontrollerconfig branch from 8836358 to 04e5c8b Compare February 16, 2024 22:58
@dmitryax dmitryax merged commit 0ab8f44 into open-telemetry:main Feb 16, 2024
45 of 46 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 16, 2024
@atoulme atoulme deleted the scrapercontrollersettings_scrapercontrollerconfig branch February 16, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants