[confighttp] Deprecate HTTPServerSettings, use HTTPServerConfig instead #9405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9405 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 345 345
Lines 18019 18019
=======================================
Hits 16260 16260
Misses 1431 1431
Partials 328 328 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Jan 26, 2024
dmitryax
approved these changes
Jan 26, 2024
dmitryax
reviewed
Jan 29, 2024
| @@ -22,7 +22,7 @@ const ( | |||
| ) | |||
|
|
|||
| type HTTPConfig struct { | |||
| *confighttp.HTTPServerSettings `mapstructure:",squash"` | |||
| *confighttp.HTTPServerConfig `mapstructure:",squash"` | |||
bogdandrutu
pushed a commit
that referenced
this pull request
Jan 30, 2024
…g for otlpreceiver Config (#9418) **Description:** add missing changelog for HTTPServerSettings->HTTPServerConfig for otlpreceiver Config **Link to tracking Issue:** #9405 (comment) --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate HTTPServerSettings, use HTTPServerConfig instead
Link to tracking Issue:
#6767