Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp] Deprecate HTTPClientSettings, use HTTPClientConfig instead #9404

Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 26, 2024

Description:
Deprecate HTTPClientSettings, use HTTPClientConfig instead

Link to tracking Issue:
#6767

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9082cb1) 90.23% compared to head (de4bbbf) 90.18%.
Report is 1 commits behind head on main.

Files Patch % Lines
config/confighttp/confighttp.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9404      +/-   ##
==========================================
- Coverage   90.23%   90.18%   -0.06%     
==========================================
  Files         345      345              
  Lines       18019    18021       +2     
==========================================
- Hits        16260    16252       -8     
- Misses       1431     1439       +8     
- Partials      328      330       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme force-pushed the httpclientsettings_httpclientconfig branch from 35c40cc to 0a18b1f Compare January 26, 2024 07:30
@atoulme atoulme force-pushed the httpclientsettings_httpclientconfig branch from 0a18b1f to f940ec2 Compare January 26, 2024 07:38
@dmitryax dmitryax merged commit 1ed45ec into open-telemetry:main Jan 29, 2024
33 of 35 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 29, 2024
@atoulme atoulme deleted the httpclientsettings_httpclientconfig branch January 29, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants