[chore] [cmd/mdatagen] Rename structs with Settings suffix to Config #21522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
djaglowski,
codeboten,
atoulme,
dashpole and
MovieStoreGuy
as code owners
github-actions
bot
added
cmd/mdatagen
github-actions
bot
added
receiver/rabbitmq
receiver/redis
github-actions
bot
requested review from
antonblock,
armstrmi,
BinaryFissionGames,
cpheps,
crobert-1,
dehaansa,
jamesmoessis,
JonathanWamsley,
Mrod1598,
nslaughter,
rmfitzpatrick,
schmikei,
shalper2 and
StefanKurek
dmitryax
force-pushed
the
mdatagen-settings-config
branch
from
fd99329
to
6ee2f60
Compare
Rename generated structs for consistency with other structs representing user configuration in the collector codebase. - MetricsSettings -> MetricsConfig - MetricSettings -> MetricConfig - ResourceAttributesSettings -> ResourceAttributesConfig - ResourceAttributeSettings -> ResourceAttributeConfig
dmitryax
force-pushed
the
mdatagen-settings-config
branch
from
6ee2f60
to
9eaed4c
Compare
MovieStoreGuy
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename generated structs for consistency with other structs representing user configuration in the collector codebase.
Link to tracking Issue: open-telemetry/opentelemetry-collector#6767