Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] add support for extends, ts types and more #6656

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Mar 16, 2023

PR Checklist

Overview

New features

TODO: explain what changed

@armano2 armano2 added package: website Issues related to the @typescript-eslint website website: playground labels Mar 16, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 99af316
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6508f62c81750e00087f5cd4

@armano2
Copy link
Member Author

armano2 commented Mar 17, 2023

@JoshuaKGoldberg when you find some time can you do preliminary review on this?
git generated way to many file changes :)

@armano2 armano2 marked this pull request as ready for review March 17, 2023 22:58
@armano2 armano2 changed the title chore(website): small improvements to playground chore(website): [playground] add support for extends, ts types and more.. Mar 18, 2023
@armano2 armano2 changed the title chore(website): [playground] add support for extends, ts types and more.. chore(website): [playground] add support for extends, ts types and more Mar 18, 2023
@JoshuaKGoldberg
Copy link
Member

I will... try 🥺 😅

@JoshuaKGoldberg
Copy link
Member

cc @jakebailey @orta - if either or both of you have time, this PR might be of interest to you. See in particular the packages/website/src/components/linter/bridge.ts file for how we're using @typescript/vfs.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @armano2 this is fantastic, really great stuff! It works smoothly and the new features (types, scopes, file type, ...) are awesome.

I mainly looked at how the PlaygroundRoot component along with the component & hooks it uses. Also the new build scripts.

My biggest point of feedback would be that if you can split up the changes at all that would be really helpful for reviewing. It's a big one 😄. But if not I think it's a direct step in many positive directions from the site today, and it'd be also great to work from what's here.

LMK when it's ready for a full review! 🙌

@armano2
Copy link
Member Author

armano2 commented Mar 21, 2023

I will try to split this PR up a little

@bradzacher
Copy link
Member

would it be possible to rebase this against the v6 branch?
There are a bunch of changes we've got in v6 to the website tools - so we don't want to accidentally get into a bad state and break things if we merge this into main before v6.

@armano2
Copy link
Member Author

armano2 commented Mar 22, 2023

@bradzacher changes rebased

Base automatically changed from v6 to main July 10, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants