Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] allow to choose file extensions #6785

Merged
merged 13 commits into from
Apr 2, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Mar 28, 2023

PR Checklist

Overview

extracted from #6656

This change replaces jsx checkbox with dropdown of supported file extensions

image

ref #5449

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c5d359b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6429d2b86f5eb200089bc8e3
😎 Deploy Preview https://deploy-preview-6785--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Mar 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c5d359b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@armano2 armano2 force-pushed the chore/playground-file-type-selection branch from 0a22f1f to a77fcf0 Compare March 29, 2023 15:30
packages/website/src/components/editor/LoadedEditor.tsx Outdated Show resolved Hide resolved
Comment on lines 10 to 20
export const fileTypes: ConfigFileType[] = [
'ts',
'tsx',
'js',
'jsx',
'd.ts',
'cjs',
'mjs',
'cts',
'mts',
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be Object.values(ts.Extension) instead?

Copy link
Member Author

@armano2 armano2 Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when this variable is initialized playground and typescript is not loaded yet and we can't wait for playground to load because this is needed to define file name that is used by playground

packages/website/src/components/types.ts Outdated Show resolved Hide resolved
packages/website/src/components/Playground.tsx Outdated Show resolved Hide resolved
packages/website/src/components/OptionsSelector.tsx Outdated Show resolved Hide resolved
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Mar 30, 2023
@armano2 armano2 requested a review from bradzacher March 30, 2023 08:25
@armano2 armano2 removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 31, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/website/src/components/hooks/useHashState.ts Outdated Show resolved Hide resolved
@armano2 armano2 merged commit f83a879 into v6 Apr 2, 2023
@armano2 armano2 deleted the chore/playground-file-type-selection branch April 2, 2023 19:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants