Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] inline visual editor instead of showing modal #6813

Merged
merged 9 commits into from
Apr 3, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Apr 1, 2023

PR Checklist

Overview

  • correct issues with re-rendering and constant updating of visual editor
  • move visual editor to be displayed in place of text editor

ref #6656 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 1, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f389193
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/642b4177253f5c00083fbe0a
😎 Deploy Preview https://deploy-preview-6813--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title chore(website): [playground] correct issues with re-renders of visual… chore(website): [playground] update visual editor re-render issues Apr 1, 2023
@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4ad4efc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@armano2 armano2 marked this pull request as draft April 1, 2023 13:06
@armano2 armano2 changed the title chore(website): [playground] update visual editor re-render issues chore(website): [playground] display visual editor in left panel instead of modal Apr 1, 2023
@armano2 armano2 changed the title chore(website): [playground] display visual editor in left panel instead of modal chore(website): [playground] inline visual editor instead of showing modal Apr 1, 2023
@armano2 armano2 marked this pull request as ready for review April 1, 2023 21:55
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES so hyped for this!! Love it!

packages/website/src/components/Playground.tsx Outdated Show resolved Hide resolved
@armano2 armano2 merged commit efd6ca9 into v6 Apr 3, 2023
@armano2 armano2 deleted the fix/correct-issues-with-rerended-of-config-editor branch April 3, 2023 21:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants