Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] improve design of error viewer #6738

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Mar 22, 2023

PR Checklist

Overview

migrate error viewer changes from #6656

notable changes:

  • alerts have consistent small spacing between them
  • text is printed as monospace font
  • text is wrapped

image image

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 613ff12
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/641b4c61eafdaa0008d97fba
😎 Deploy Preview https://deploy-preview-6738--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 613ff12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #6738 (613ff12) into v6 (f84bf4a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6738      +/-   ##
==========================================
- Coverage   87.40%   87.36%   -0.04%     
==========================================
  Files         373      373              
  Lines       12844    12800      -44     
  Branches     3811     3793      -18     
==========================================
- Hits        11226    11183      -43     
  Misses       1232     1232              
+ Partials      386      385       -1     
Flag Coverage Δ
unittest 87.36% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

packages/website/src/components/ErrorsViewer.tsx Outdated Show resolved Hide resolved
@armano2 armano2 changed the title chore(website): improve design of error viewer chore(website): [playground] improve design of error viewer Mar 26, 2023
@armano2 armano2 merged commit 45991b3 into v6 Mar 27, 2023
@armano2 armano2 deleted the chore/website-error-viewer-correct-design-issues branch March 27, 2023 07:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants