Fix Literal bug with typing-extension==4.6.0 #5826

hramezani · 2023-05-23T10:17:04Z

cloudflare-pages · 2023-05-23T10:19:12Z

Deploying with Cloudflare Pages

Latest commit:	`2ed3ca1`
Status:	🚫 Build failed.

View logs

pydantic/typing.py

AlexWaygood

I'm not familiar with pydantic internals, but this looks like a reasonable fix to me!

tests/test_typing.py

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

hramezani · 2023-05-23T10:40:53Z

I'm not familiar with pydantic internals, but this looks like a reasonable fix to me!

Sure. Thanks!

smartYSC · 2023-05-23T11:09:08Z

Will this fix be delivered as Pydantic 1.10.8 immediately? If yes, I will wait and not implement any workarounds.

sanderr · 2023-05-23T11:18:25Z

I wonder if it might not be a good idea to introduce an upper bound (<5) on the typing-extensions package as well. The project declares that they follow semantic versioning so they should only introduce breaking changes in major releases. Given how this issue has caused problems on a lot of projects, I think it would be a good idea to protect against similar issues when typing-extensions gets a major release. It wouldn't have prevented this specific issue because this really was a bug in pydantic, but it could help prevent similar issues in the future.

The same applies to the master branch of course.

AlexWaygood · 2023-05-23T11:24:44Z

Honestly, I feel like this situation illustrates the inadequacies of SemVer more than anything else

samuelcolvin · 2023-05-23T11:33:12Z

Honestly, I feel like this situation illustrates the inadequacies of SemVer more than anything else

agreed.

I wonder if it might not be a good idea to introduce an upper bound (<5) on the typing-extensions package as well.

No. There are many articles out there about why including upper bounds in package dependencies is almost always a bad idea.

Will this fix be delivered as Pydantic 1.10.8 immediately? If yes, I will wait and not implement any workarounds.

We'll do our best to get it out asap.

AlexWaygood · 2023-05-23T11:37:11Z

Although I don't feel like typing_extensions is at fault here (and this was a change that pydantic folks originally asked for, anyway 😉), I would nonetheless like to apologise for the breakage here. I didn't anticipate that reimplementing Literal on Python 3.8-3.9 at typing_extensions could have the capacity to break pydantic in this way and cause so much disruption.

samuelcolvin · 2023-05-23T11:39:19Z

No problem @AlexWaygood, these things happen. It's the responsibility of app developers to pin dependencies.

CF build failures is a random download issue, see my angry tweet.

samuelcolvin

otherwise LGTM.

samuelcolvin · 2023-05-23T11:43:19Z

pydantic/typing.py

-            if type_ is none_type:
-                return True
-        return False
+        return type_ in NONE_TYPES


This looks weird enough that we might have done it for some strange reason, can we confirm this was just a code smell?

The existing approach(checking with is) does not work in Python 3.9 and typing-extension==4.6.0. That's why I've changed it.

Note: the new approach is also Ok with typing-extension==4.5.0. So, it might be a wrong implementation before

thanks @hramezani.

Can we uprev the version we test with?

(pydantic/pydantic#5826)

dmontagu · 2023-05-23T17:59:08Z

This should be fixed now in the just-released 1.10.8, which should be available through PyPI shortly.

samuelcolvin · 2023-05-23T18:30:01Z

This should be fixed now in the just-released 1.10.8, which should be available through PyPI shortly.

Done

pydantic/pydantic#5826

Fix Literal bug with typing-extension==4.6.0

93ef367

hramezani force-pushed the is_literal_type branch from 7f0a4d5 to 93ef367 Compare May 23, 2023 10:19

AlexWaygood reviewed May 23, 2023

View reviewed changes

pydantic/typing.py Outdated Show resolved Hide resolved

Change LITERAL_TYPES type

bb4cfa8

AlexWaygood reviewed May 23, 2023

View reviewed changes

tests/test_typing.py Outdated Show resolved Hide resolved

Update tests/test_typing.py

c009124

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood mentioned this pull request May 23, 2023

is_literal broken with new typing_extensions ilevkivskyi/typing_inspect#100

Closed

Fix is_none_type

aab48c9

hramezani force-pushed the is_literal_type branch from 989eecb to aab48c9 Compare May 23, 2023 11:14

hramezani requested a review from samuelcolvin May 23, 2023 11:26

AlexWaygood mentioned this pull request May 23, 2023

TypeError: issubclass() arg 1 must be a class with version 4.6.0 with pydantic python/typing_extensions#179

Closed

samuelcolvin reviewed May 23, 2023

View reviewed changes

uprev typing-extension to 4.6.0

188bf69

mirekdlugosz mentioned this pull request May 23, 2023

Add data provider quipucords/camayoc#391

Merged

tand826 mentioned this pull request May 23, 2023

import langchain with python<=3.9 fails langchain-ai/langchain#5113

Closed

14 tasks

bump

2ed3ca1

dmontagu approved these changes May 23, 2023

View reviewed changes

tcompa mentioned this pull request May 23, 2023

Undo poetry add typing_extensions==4.5.0 fractal-analytics-platform/fractal-client#487

Closed

mikeweltevrede mentioned this pull request May 23, 2023

typing_extensions 4.6.0 causes pydantic issues databrickslabs/dbx#785

Closed

tcompa mentioned this pull request May 23, 2023

Unpin typing-extensions version fractal-analytics-platform/fractal-common#61

Closed

bdura added a commit to explosion/spacy-llm that referenced this pull request May 23, 2023

ci: temporarily disable fail-fast

2ca6422

(pydantic/pydantic#5826)

bdura mentioned this pull request May 23, 2023

ci: temporarily disable fail-fast explosion/spacy-llm#116

Merged

5 tasks

rmitsch pushed a commit to explosion/spacy-llm that referenced this pull request May 23, 2023

ci: temporarily disable fail-fast (#116)

0687232

(pydantic/pydantic#5826)

hramezani merged commit c4d3dee into 1.10.X-fixes May 23, 2023
49 of 50 checks passed

hramezani deleted the is_literal_type branch May 23, 2023 14:44

stefsmeets mentioned this pull request May 23, 2023

Docs are broken duqtools/duqtools#616

Closed

AlexWaygood mentioned this pull request May 23, 2023

Release 4.6.0 breaks Pydantic 1.9.2 python/typing_extensions#183

Closed

desertaxle mentioned this pull request May 23, 2023

Flow runs failing due to pydantic duplicate validator function error PrefectHQ/prefect#9700

Closed

4 tasks

Kilo59 mentioned this pull request May 23, 2023

[MAINTENANCE] Update Cloud Tests for release this week + Revert pin on typing-extension great-expectations/great_expectations#7980

Merged

4 tasks

JaskRendix mentioned this pull request May 23, 2023

Python 3.9 tests failing Tuxemon/Tuxemon#1867

Closed

AlexWaygood mentioned this pull request May 26, 2023

Add introspection helper functions for third-party libraries python/typing_extensions#203

Closed

temichus mentioned this pull request May 29, 2023

fix(Argus): fix issue regarding catch failed runs scylladb/scylla-cluster-tests#6196

Merged

7 tasks

This was referenced Jun 1, 2023

Python: Remove typing-extensions pin tabular-io/docker-spark-iceberg#83

Closed

pyiceberg pydantic failed with new typing-extension package apache/iceberg#7746

Closed

Python: Loosen dependency on typing-extensions apache/iceberg#7747

Merged

frnhr added a commit to cognitedata/pygen that referenced this pull request Jun 9, 2023

typing-extensions 4.6 broke pydantic

9e5f16a

pydantic/pydantic#5826

frnhr mentioned this pull request Jun 9, 2023

fix for Python 3.9, typing-extensions broke pydantic cognitedata/pygen#14

Closed

4 tasks

devstein mentioned this pull request Jun 16, 2023

Can not import NotRequired from typing_extensions.py langchain-ai/langchain#6245

Closed

14 tasks

This was referenced Jul 8, 2023

Broken Dependency with Qdrant-Client on Replit qdrant/qdrant-client#200

Closed

new: update pydantic, unfreeze typing-extensions qdrant/qdrant-client#203

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Literal bug with typing-extension==4.6.0 #5826

Fix Literal bug with typing-extension==4.6.0 #5826

hramezani commented May 23, 2023

cloudflare-pages bot commented May 23, 2023 •

edited

AlexWaygood left a comment

hramezani commented May 23, 2023

smartYSC commented May 23, 2023

sanderr commented May 23, 2023

AlexWaygood commented May 23, 2023

samuelcolvin commented May 23, 2023 •

edited

AlexWaygood commented May 23, 2023 •

edited

samuelcolvin commented May 23, 2023

samuelcolvin left a comment

samuelcolvin May 23, 2023

hramezani May 23, 2023 •

edited

samuelcolvin May 23, 2023

hramezani May 23, 2023

dmontagu commented May 23, 2023

samuelcolvin commented May 23, 2023

Fix Literal bug with typing-extension==4.6.0 #5826

Fix Literal bug with typing-extension==4.6.0 #5826

Conversation

hramezani commented May 23, 2023

cloudflare-pages bot commented May 23, 2023 • edited

Deploying with Cloudflare Pages

AlexWaygood left a comment

Choose a reason for hiding this comment

hramezani commented May 23, 2023

smartYSC commented May 23, 2023

sanderr commented May 23, 2023

AlexWaygood commented May 23, 2023

samuelcolvin commented May 23, 2023 • edited

AlexWaygood commented May 23, 2023 • edited

samuelcolvin commented May 23, 2023

samuelcolvin left a comment

Choose a reason for hiding this comment

samuelcolvin May 23, 2023

Choose a reason for hiding this comment

hramezani May 23, 2023 • edited

Choose a reason for hiding this comment

samuelcolvin May 23, 2023

Choose a reason for hiding this comment

hramezani May 23, 2023

Choose a reason for hiding this comment

dmontagu commented May 23, 2023

samuelcolvin commented May 23, 2023

cloudflare-pages bot commented May 23, 2023 •

edited

samuelcolvin commented May 23, 2023 •

edited

AlexWaygood commented May 23, 2023 •

edited

hramezani May 23, 2023 •

edited