new: update pydantic, unfreeze typing-extensions #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Same would absolutely love to see this merged! |
|
can be closed in favour of #214 |
generall
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue #175
It seemed like it was due to a problem with
typing-extensionsversion, but actually it waspydantic's incorrect behaviour.As it stated here.
pydantic<1.10.8does not work withtyping-extensions>=4.6.0, howeverpydantic>=1.10.8works withtyping-extensions>=4.2.0I think it is not right to fix
typing-extensions>=4.0.0,<=4.6.0and suggest to update pydantic instead.Also
pydantic>=2.0.0has requirestyping-extensions>=4.6.1