[MAINTENANCE] Update Cloud Tests for release this week + Revert pin on typing-extension
#7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…include_rendered_content
…include_rendered_content
Kilo59
commented
May 23, 2023
| @@ -31,6 +31,6 @@ requests>=2.20 | |||
| ruamel.yaml>=0.16,<0.17.18 # See https://github.com/great-expectations/great_expectations/issues/4152 | |||
| scipy>=1.6.0 | |||
| tqdm>=4.59.0 | |||
| typing-extensions>=3.10.0.0,<4.6.0 # Leverage type annotations from recent Python releases | |||
| typing-extensions>=3.10.0.0 # Leverage type annotations from recent Python releases | |||
There was a problem hiding this comment.
Removed this pin due to this fix in pydantic and subsequent release
Shinnnyshinshin
changed the title
typing-extension
| return [ | ||
| ( | ||
| GXCloudRESTResource.EXPECTATION_SUITE, | ||
| "1212e79d-f751-4c6e-921d-26de2b1db174", |
There was a problem hiding this comment.
@Shinnnyshinshin was this key generated by GX-Cloud for the test? Thanks.
There was a problem hiding this comment.
Hi @alexsherstinsky great question. It's actually part of a fixture that is used in a Mock:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests for release
typing-extensionpackage version #7970, and [DOCS] Temporarily pin typing-extensions for API docs #7977, which was addressed by an updatedtyping-extensionspackageDescription of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted
Appropriate tests and docs have been updated
For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!