fix(Argus): fix issue regarding catch failed runs #6196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temichus
force-pushed
the
fix_catch_failed_runs_earlier
branch
2 times, most recently
from
ad563f2
to
eede9fa
Compare
Since we are now creating argus run even before sct runner is created we need to use new argus client enpoind to post sct runner infor when it is created
temichus
force-pushed
the
fix_catch_failed_runs_earlier
branch
from
eede9fa
to
faa79d6
Compare
|
fix tested together with @k0machi |
k0machi
approved these changes
May 29, 2023
|
related Argus changes scylladb/argus#250 scylladb/argus#251 |
juliayakovlev
approved these changes
May 29, 2023
fruch
reviewed
May 29, 2023
| @@ -52,3 +52,4 @@ questionary==1.10.0 | |||
| pbr==1.4 | |||
| hdrhistogram==0.9.2 | |||
| deepdiff==6.2.3 | |||
| typing-extensions==4.5.0 | |||
There was a problem hiding this comment.
Why are we pinning this one and not upgrading pydantic?
This was referenced May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now creating argus run even before sct runner is created we need to use new argus client enpoind to post sct runner infor when it is created
set typing-extensions==4.5.0 due to bug pydantic/pydantic#5826 in pydantic==1.8.2
PR pre-checks (self review)
backportlabelssdcm/sct_config.py)unit-test/folder)