New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcListItem): add title slot #5388
Conversation
/backport to next |
b7b2e36
to
937ddde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add a new slot here, we need to also check that it works well with compact
mode and the new one-line
mode and support it.
If this slot is only needed for this specific place, I'd consider this PR as an alternative #3715
So we can provide custom content to name
same as currently similar design is implemented in file_versions via #subname
.
cc @nextcloud-libraries/designers for a design view here.
This makes sense to me. Would also favor this solution. |
After looking at the PR, I agree. This solution is much cleaner, as well! I will manually import the changes that PR introduced but still tag the original PR author. |
937ddde
to
60226db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here we are again 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a design perspective this is a great idea :) there have been multiple times where we've tried to have different styling for the title but it wasn't possible due to the limitations of the component.
I would suggest that text in all the slots be bold by default to maintain consistency.
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
60226db
to
a6faa9e
Compare
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
a6faa9e
to
6287dac
Compare
Fixed with @Antreesy 's PR :D |
Summary
To extend component flexibility, allow component to be able to render content to the side of name. For instance, in my case, I need to be able to add content to the side of the name for a customer request feature. However, the current implementation keeps the whole line one bolded, and for design reasons, it would be better to allow users of the library to manually style their side content.
Any input on how to better name the slot is appreciate as well :) I did not have any good naming convention to describe
content that aligns right to the name of line one
🖼️ Screenshots
🏁 Checklist
next
requested with a Vue 3 upgrade