Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: author displayname and avatar on versions #44109

Merged
merged 3 commits into from
Mar 15, 2024
Merged

feat: author displayname and avatar on versions #44109

merged 3 commits into from
Mar 15, 2024

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Mar 9, 2024 •
edited by susnux

This is a stacked PR

Summary

With the aforementioned PR's, this PR will allow file_version to display the author and avatar for each version

馃彙 New View
Code_Ek3YHm9VcZ

Checklist

@emoral435 emoral435 added this to the Nextcloud 29 milestone Mar 9, 2024
@emoral435 emoral435 self-assigned this Mar 9, 2024
This was referenced Mar 9, 2024
Merged
Merged
@emoral435 emoral435 force-pushed the feat/frontend-change-for-version-author branch from 7049690 to 5f16f3c Compare March 10, 2024 15:01
@emoral435 emoral435 force-pushed the feat/show-name-of-user-in-versions branch 3 times, most recently from 148aa46 to bfacc6d Compare March 11, 2024 20:58
Base automatically changed from feat/show-name-of-user-in-versions to master March 11, 2024 21:17
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@emoral435 emoral435 force-pushed the feat/frontend-change-for-version-author branch from 5f16f3c to 08c71bc Compare March 13, 2024 15:35
@Altahrim Altahrim mentioned this pull request Mar 14, 2024
Merged
@emoral435 emoral435 force-pushed the feat/frontend-change-for-version-author branch from 08c71bc to eba635d Compare March 14, 2024 13:51
@emoral435 emoral435 marked this pull request as ready for review March 14, 2024 13:51
@emoral435
Copy link
Contributor Author

This PR will only show the visual changes once NcVue gets a bump to use one of the chained PR's, but for now, no breaking changes are introduced with this PR, so this can get in before I go on vacation 馃憖

nimishavijay
nimishavijay requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment •
edited by emoral435

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! What a cool feature! :)

  • I would only suggest that the positions of the avatar and name be exchanged, and the avatar size be decreased so that it looks a bit more like a user bubble
  • everything in the first time can be in --color-main-text and everything on the subline can be --color-text-maxcontrast :)

image

@emoral435 emoral435 force-pushed the feat/frontend-change-for-version-author branch from eba635d to bcff895 Compare March 14, 2024 21:05
@emoral435
Copy link
Contributor Author

image

@nimishavijay
I moved around the icon and the display name, and then fixed the coloring of the text :)

@emoral435 emoral435 force-pushed the feat/frontend-change-for-version-author branch from bcff895 to 3d01107 Compare March 14, 2024 21:07
@emoral435 emoral435 requested a review from susnux March 14, 2024 21:08
@emoral435
Copy link
Contributor Author

waiting for a bump to NcVue and then this PR is ready :)

nimishavijay
nimishavijay approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

@emoral435 @susnux
feat: author displayname and avatar on versions
e03c74a 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@susnux susnux force-pushed the feat/frontend-change-for-version-author branch from 3d01107 to ac62523 Compare March 15, 2024 19:13
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 15, 2024
@susnux
Copy link
Contributor

susnux commented Mar 15, 2024

/compile

@emoral435
fix: made author-icon smaller and added try-catch
4bfbcad 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435
chore(assets): compiled assets
56eebaf 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the feat/frontend-change-for-version-author branch from cefe7bf to 56eebaf Compare March 15, 2024 22:24
@emoral435 emoral435 merged commit 0208d83 into master Mar 15, 2024
104 checks passed
@emoral435 emoral435 deleted the feat/frontend-change-for-version-author branch March 15, 2024 22:44
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@emoral435 emoral435

Labels
3. to review Waiting for reviews enhancement feature: versions
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Version authors
4 participants
@emoral435 @susnux @artonge @nimishavijay