Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): bring back old styling for two-line list items #5400

Merged
merged 1 commit into from Mar 12, 2024
Merged

fix(NcListItem): bring back old styling for two-line list items #5400

merged 1 commit into from Mar 12, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 12, 2024 •
edited

☑️ Resolves

🖼️ Screenshots

🏡 Old Before 🏚️ Before 🏡 After
image image image

Tip

As name is bold in one-line, you might have to use :deep selector to overwrite this or use a name slot (#5388)
image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcListItem): bring back old styling for two-line list items
510a18b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review Waiting for reviews regression Regression of a previous working feature feature: list-item Related to the list-item component labels Mar 12, 2024
@Antreesy Antreesy added this to the 8.10.1 milestone Mar 12, 2024
@Antreesy Antreesy self-assigned this Mar 12, 2024
GretaD
GretaD approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with mail

@Antreesy Antreesy merged commit 1bb6ff4 into master Mar 12, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/5209-make-listitem-bold-again branch March 12, 2024 10:34
This was referenced Mar 12, 2024
Merged
Merged
@ShGKme ShGKme added the bug Something isn't working label Mar 15, 2024
@ShGKme ShGKme modified the milestones: 8.10.1, 8.11.0 Mar 15, 2024
@Antreesy Antreesy mentioned this pull request Mar 15, 2024
Merged
@Antreesy
Copy link
Contributor Author

/backport to next

@backportbot backportbot bot mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD GretaD approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component regression Regression of a previous working feature
Projects
None yet
Milestone
8.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Antreesy @ChristophWurst @GretaD @ShGKme