Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat: add title slot for NcItemList component #5402

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[next] feat: add title slot for NcItemList component #5402

merged 2 commits into from
Mar 14, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 12, 2024 •
edited by emoral435

Backport of #5388

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@emoral435 @backportbot
feat: added extra name side content slot
19d301d 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews component Component discussion and/or suggestion feature: list-item Related to the list-item component labels Mar 12, 2024
@emoral435
Copy link
Contributor

changes fixed - backport now fully has PR content 👍

@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 13, 2024
@Antreesy Antreesy marked this pull request as ready for review March 13, 2024 16:22
@ShGKme
Copy link
Contributor

ShGKme commented Mar 13, 2024

[x] Amend HEAD commit to remove the line stating to skip CI

The commit still has [skip CI]

@emoral435
feat: added extra doc to show slot usage
64ff0e3 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435
Copy link
Contributor

The commit still has [skip CI]

Fixed! Didn't catch that

@emoral435 emoral435 merged commit 14f94d0 into next Mar 14, 2024
17 checks passed
@emoral435 emoral435 deleted the backport/5388/next branch March 14, 2024 13:01
@ShGKme ShGKme mentioned this pull request Mar 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

@emoral435 emoral435 emoral435 approved these changes

Assignees

@emoral435 emoral435

Labels
4. to release Ready to be released and/or waiting for tests to finish component Component discussion and/or suggestion enhancement New feature or request feature: list-item Related to the list-item component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emoral435 @ShGKme @Antreesy