SonarLintXmlReader refactoring #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
changed the base branch from
master
to
feature/SL-exclusions-inclusions
pavel-mikula-sonarsource
force-pushed
the
feature/SL-exclusions-inclusions
branch
from
262b3b7
to
e841ab6
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/cleanup
branch
from
49b29b9
to
bc2a5d2
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/cleanup
branch
2 times, most recently
from
285749b
to
09536d2
Compare
mary-georgiou-sonarsource
changed the title
mary-georgiou-sonarsource
force-pushed
the
mary/cleanup
branch
3 times, most recently
from
1796226
to
9289fca
Compare
mary-georgiou-sonarsource
requested a review
from cristian-ambrosini-sonarsource
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned mary-georgiou-sonarsource
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
approved these changes
Mar 16, 2023
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned cristian-ambrosini-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
cristian-ambrosini-sonarsource
moved this from Review approved
to Review in progress
in Best Kanban
cristian-ambrosini-sonarsource
requested a review
from pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
requested changes
Mar 16, 2023
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
github-actions
bot
moved this from Review approved
to Review in progress
in Best Kanban
pavel-mikula-sonarsource
approved these changes
Mar 20, 2023
analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
mary-georgiou-sonarsource
moved this from Review approved
to Review in progress
in Best Kanban
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
mary-georgiou-sonarsource
force-pushed
the
mary/cleanup
branch
from
c555e5a
to
00c54dc
Compare
pavel-mikula-sonarsource
approved these changes
Mar 21, 2023
| @@ -82,6 +82,22 @@ public void SonarLintXmlReader_PropertiesCSharpTrueVBNetFalse_ExpectedValues() | |||
| sut.AnalyzeGeneratedCode(LanguageNames.VisualBasic).Should().BeFalse(); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void SonarLintXmlReader_DuplicatedProperties_DoesNotFail() | |||
| { | |||
There was a problem hiding this comment.
Throwing is asserted via lambdas.
Suggested change
| { | |
| public void SonarLintXmlReader_DuplicatedProperties_DoesNotFail() => | |
| ((Action)(() => CreateSonarLintXmlReader("ResourceTests\\SonarLintXml\\Duplicated_Properties\\SonarLint.xml"))).Should().NotThrow(); |
There was a problem hiding this comment.
I strongly prefer @"asdf\asdf" over double \\ - this applies everywhere. The \\ is cumbersome to work with, copy paste and use in general.
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments from #6870