cover case of duplicate keys in sonarlint xml

SonarSource · Mar 21, 2023 · 00c54dc · 00c54dc
1 parent 0424e30
commit 00c54dc
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 1 deletion.
diff --git a/analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs b/analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs
@@ -43,7 +43,7 @@ public class SonarLintXmlReader
     public SonarLintXmlReader(SourceText sonarLintXmlText)
     {
         var sonarLintXml = ParseContent(sonarLintXmlText);
-        var settings = sonarLintXml.Settings?.ToDictionary(x => x.Key, x => x.Value) ?? new Dictionary<string, string>();
+        var settings = sonarLintXml.Settings?.GroupBy(x => x.Key).ToDictionary(x => x.Key, x => x.First().Value) ?? new Dictionary<string, string>();
         Exclusions = ReadArray("sonar.exclusions");
         Inclusions = ReadArray("sonar.inclusions");
         GlobalExclusions = ReadArray("sonar.global.exclusions");

diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/Helpers/SonarLintXmlReaderTest.cs b/analyzers/tests/SonarAnalyzer.UnitTest/Helpers/SonarLintXmlReaderTest.cs
@@ -82,6 +82,22 @@ public void SonarLintXmlReader_PropertiesCSharpTrueVBNetFalse_ExpectedValues()
         sut.AnalyzeGeneratedCode(LanguageNames.VisualBasic).Should().BeFalse();
     }
 
+    [TestMethod]
+    public void SonarLintXmlReader_DuplicatedProperties_DoesNotFail()
+    {
+        try
+        {
+            _ = CreateSonarLintXmlReader("ResourceTests\\SonarLintXml\\Duplicated_Properties\\SonarLint.xml");
+        }
+        catch (ArgumentException ex)
+        {
+            if (ex.Message.Contains("An item with the same key has already been added."))
+            {
+                Assert.Fail("Expected no exception, but got: " + ex.Message);
+            }
+        }
+    }
+
     [DataTestMethod]
     [DataRow("")]
     [DataRow("this is not an xml")]

diff --git a/...sts/SonarAnalyzer.UnitTest/ResourceTests/SonarLintXml/Duplicated_Properties/SonarLint.xml b/...sts/SonarAnalyzer.UnitTest/ResourceTests/SonarLintXml/Duplicated_Properties/SonarLint.xml
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<AnalysisInput>
+  <Settings>
+    <Setting>
+      <Key>sonar.cs.ignoreHeaderComments</Key>
+      <Value>true</Value>
+    </Setting>
+    <Setting>
+      <Key>sonar.cs.ignoreHeaderComments</Key>
+      <Value>true</Value>
+    </Setting>
+    <Setting>
+      <Key>sonar.cs.analyzeGeneratedCode</Key>
+      <Value>true</Value>
+    </Setting>
+    <Setting>
+      <Key>sonar.cs.analyzeGeneratedCode</Key>
+      <Value>false</Value>
+    </Setting>
+    <Setting>
+      <Key>sonar.exclusions</Key>
+      <Value>Fake/Exclusions/**/*,Fake/Exclusions/Second*/**/*</Value>
+    </Setting>
+    <Setting>
+      <Key>sonar.exclusions</Key>
+      <Value>Fake/Inclusions/**/*</Value>
+    </Setting>
+  </Settings>
+</AnalysisInput>