Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exclusion and inclusion parameters when run by SonarLint #6870

Merged
merged 14 commits into from Mar 16, 2023
Merged

Support exclusion and inclusion parameters when run by SonarLint #6870

merged 14 commits into from Mar 16, 2023

Conversation

csaba-sagi-sonarsource
Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource commented Mar 7, 2023 •
edited

Fixes #6877

@github-actions github-actions bot added this to In progress in Best Kanban Mar 7, 2023
@csaba-sagi-sonarsource csaba-sagi-sonarsource removed this from In progress in Best Kanban Mar 8, 2023
mary-georgiou-sonarsource
mary-georgiou-sonarsource requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a snapshot of the peach before merging this PR.

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following what was done ProjectConfig caused some troubles that we'll need to fix.

I didn't want to review the WildcardPatternMatcher, but from a quick look I spotted quite some concerning things.

analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs Outdated Show resolved Hide resolved
Merged
@pavel-mikula-sonarsource pavel-mikula-sonarsource force-pushed the feature/SL-exclusions-inclusions branch 2 times, most recently from 7fd2fc3 to 262b3b7 Compare March 14, 2023 09:27
This was referenced Mar 15, 2023
Merged
Merged
@mary-georgiou-sonarsource mary-georgiou-sonarsource mentioned this pull request Mar 15, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

98.6% 98.6% Coverage
0.0% 0.0% Duplication

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot taken

@csaba-sagi-sonarsource csaba-sagi-sonarsource marked this pull request as ready for review March 16, 2023 15:59
pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with respect to the last PR that is coming. This can be merged to shorten the validation loop

@csaba-sagi-sonarsource csaba-sagi-sonarsource merged commit 4db4ba1 into master Mar 16, 2023
30 checks passed
@csaba-sagi-sonarsource csaba-sagi-sonarsource deleted the feature/SL-exclusions-inclusions branch March 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource left review comments

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@csaba-sagi-sonarsource csaba-sagi-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support exclusion and inclusion parameters when run by SonarLint
4 participants
@csaba-sagi-sonarsource @pavel-mikula-sonarsource @mary-georgiou-sonarsource @cristian-ambrosini-sonarsource