Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarLintXmlReader refactoring #6924

Merged
merged 17 commits into from Mar 21, 2023
Merged

SonarLintXmlReader refactoring #6924

merged 17 commits into from Mar 21, 2023

Commits on Mar 20, 2023

  1. transport methods from SonarAnalysisContext to SonarLintXmlReader

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6e6f250 View commit details
    Browse the repository at this point in the history

  2. fix comment

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    22b698a View commit details
    Browse the repository at this point in the history

  3. remove backing fields - read everything in the constructor

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    706e876 View commit details
    Browse the repository at this point in the history

  4. fix after rebase

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6519227 View commit details
    Browse the repository at this point in the history

  5. fix after rebase

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7267472 View commit details
    Browse the repository at this point in the history

  6. Add missing tabs

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bc7aefd View commit details
    Browse the repository at this point in the history

  7. apply comments

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2f14c7d View commit details
    Browse the repository at this point in the history

  8. Turn settings to a dictionary so that its better to the eyes

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bc2ec8c View commit details
    Browse the repository at this point in the history

  9. Remove check if SL is already read

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bc92dd6 View commit details
    Browse the repository at this point in the history

  10. re-arrange methods

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    78229f4 View commit details
    Browse the repository at this point in the history

  11. apply pair programming changes

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d9d3f19 View commit details
    Browse the repository at this point in the history

  12. make bool fields readonly

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    de5dd42 View commit details
    Browse the repository at this point in the history

  13. fix UTs

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    017ac16 View commit details
    Browse the repository at this point in the history

  14. Update condition 

    Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
    @mary-georgiou-sonarsource @pavel-mikula-sonarsource
    mary-georgiou-sonarsource and pavel-mikula-sonarsource committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0424e30 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. cover case of duplicate keys in sonarlint xml

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    00c54dc View commit details
    Browse the repository at this point in the history

  2. test not throwing with action and make all paths verbatim strings

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f3adb1c View commit details
    Browse the repository at this point in the history

  3. fix paths

    @mary-georgiou-sonarsource
    mary-georgiou-sonarsource committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1cf7c28 View commit details
    Browse the repository at this point in the history