Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] regression fix for parsing comments #6768

Merged
merged 1 commit into from Mar 27, 2023

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Mar 25, 2023

PR Checklist

Overview

Add missing required field codeFullText to v6 playground

eg. comments where not parsed correctly

/* eslint "@typescript-eslint/no-unused-vars": "error" */

const x = 2

playground this branch
playground v6

@typescript-eslint

This comment was marked as resolved.

@netlify
Copy link

netlify bot commented Mar 25, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c96e412
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/641ec34f7b7a7500081d4c97
😎 Deploy Preview https://deploy-preview-6768--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title chore(website): correct issues with parsing code in playground chore(website): [playground] correct issues with parsing code Mar 25, 2023
@nx-cloud
Copy link

nx-cloud bot commented Mar 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c96e412. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #6768 (c96e412) into v6 (f84bf4a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6768      +/-   ##
==========================================
- Coverage   87.40%   87.36%   -0.04%     
==========================================
  Files         373      373              
  Lines       12844    12800      -44     
  Branches     3811     3793      -18     
==========================================
- Hits        11226    11183      -43     
  Misses       1232     1232              
+ Partials      386      385       -1     
Flag Coverage Δ
unittest 87.36% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@armano2 armano2 changed the title chore(website): [playground] correct issues with parsing code chore(website): [playground] regression fix for parsing comments Mar 27, 2023
@armano2 armano2 merged commit 5f5bde4 into v6 Mar 27, 2023
45 checks passed
@armano2 armano2 deleted the fix/v6-playground-comments branch March 27, 2023 07:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants