Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: [Playground] ast viewer should display comments and tokens #6769

Closed
2 tasks done
armano2 opened this issue Mar 25, 2023 · 1 comment
Closed
2 tasks done

Website: [Playground] ast viewer should display comments and tokens #6769

armano2 opened this issue Mar 25, 2023 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website website: playground

Comments

@armano2
Copy link
Member

armano2 commented Mar 25, 2023

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

while debugging issue #6768 and trying to reproduce it in playground i stumbled upon issue with playground not displaying comments correctly

note:

Affected URL(s)

https://typescript-eslint.io/play/

@armano2 armano2 added accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website website: playground labels Mar 25, 2023
@bradzacher
Copy link
Member

Tokens might be nice behind a flag, comments probably always.

I was actually just thinking about this the other day as I was looking into the hashbang comments!

@armano2 armano2 closed this as completed Jun 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Development

No branches or pull requests

2 participants