fix(typescript-estree): allow writing to deprecated node properties

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes typescript-estree: allow setting deprecated node properties #6668
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

In the node's Object.defineProperty accessor descriptor, it's now given a setter that sets it to a data descriptor. See terminology on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	71b51c9
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64184f33ff77f2000779273b
😎 Deploy Preview	https://deploy-preview-6670--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71b51c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 30 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• nx run-many --target=build --projects=website-eslint,website
• Node 18 - nx test typescript-estree
• nx run-many --target=lint --parallel
• Node 18 - nx test scope-manager
• Node 18 - nx run types:build
• Node 18 - nx test type-utils
• nx run types:build
• Node 18 - nx test repo-tools
• Node 18 - nx test visitor-keys
• Node 18 - nx test utils
• Node 18 - nx test parser
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx test parser --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run types:build
• Node 14 - nx test ast-spec --coverage=false
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test visitor-keys --coverage=false
• Node 18 - nx test ast-spec
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test repo-tools --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

(converting to draft as I have to poke at the website build - I probably messed up something in conversion with this scope...) ✅

[codecov]

Codecov Report

Merging #6670 (b7c9677) into v6 (28a64b5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b7c9677 differs from pull request most recent head 71b51c9. Consider uploading reports for the commit 71b51c9 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##               v6    #6670   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files         372      372           
  Lines       12729    12729           
  Branches     3783     3782    -1     
=======================================
  Hits        10850    10850           
  Misses       1499     1499           
  Partials      380      380           

Flag	Coverage Δ
unittest	85.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	31.03% <100.00%> (ø)