Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript-estree: allow setting deprecated node properties #6668

Closed
JoshuaKGoldberg opened this issue Mar 18, 2023 · 1 comment
Closed

typescript-estree: allow setting deprecated node properties #6668

JoshuaKGoldberg opened this issue Mar 18, 2023 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Milestone
6.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 18, 2023 •
edited

Overview

Following #6525 (comment): turns out Prettier has logic that reassigns deprecated node properties. We'll need to allow that. Otherwise, https://github.com/prettier/prettier/actions/runs/4445538911/jobs/7804778641?pr=14429#step:4:60:

  TypeError: Cannot set property typeParameters of #<Object> which has only a getter
      at visitNode (file:///home/runner/work/prettier/prettier/src/language-js/parse/postprocess/visit-node.js:20:19)

Thanks @fisker for the comments 😄
@JoshuaKGoldberg JoshuaKGoldberg added bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree accepting prs Go ahead, send a pull request that resolves this issue labels Mar 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 18, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Mar 20, 2023
@JoshuaKGoldberg
Copy link
Member Author

Fixed by #6670.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg