Always Object.defineProperty

typescript-eslint · Mar 19, 2023 · 15e724a · 15e724a
1 parent 844391b
commit 15e724a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -3319,16 +3319,15 @@ export class Converter {
     aliasKey: AliasKey,
     valueKey: ValueKey,
   ): Properties & Record<AliasKey, Properties[ValueKey]> {
-    if (this.options.suppressDeprecatedPropertyWarnings) {
-      (node as any)[aliasKey] = node[valueKey];
-      return node as Properties & Record<AliasKey, Properties[ValueKey]>;
-    }
-
     let warned = false;
 
     Object.defineProperty(node, aliasKey, {
       configurable: true,
       get(): Properties[typeof valueKey] {
+        if (this.options.suppressDeprecatedPropertyWarnings) {
+          (node as any)[aliasKey] = node[valueKey];
+        }
+
         if (!warned) {
           // eslint-disable-next-line no-console
           console.warn(