feat(typescript-estree): remove optionality from AST boolean properties

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes AST standardisation: remove undefined/optional from node properties unless it really makes sense #5020
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Switches ?: boolean properties to : boolean in ast-spec. Updates convert.ts accordingly to always assign those properties even if they're not true.

Does not update snapshots that need manual touchups, pending resolution of whether to use this or #6273.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3743f2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 51 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test typescript-estree
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test repo-tools
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx test scope-manager
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test parser
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test typescript-estree --coverage=false
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=lint --parallel
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test ast-spec
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test parser --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test repo-tools --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[bradzacher]

This LGTM - generate all the snapshots and we can get this in.
There's too many to review by hand, but the changes themselves are all looking good!

[JoshuaKGoldberg]

Some new test failures after merge. I'm going to take a break then look at them... this is a mildly frustrating PR to work with 🙃 ✅

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	3743f2b
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63f81f90e3558300086ee6b9
😎 Deploy Preview	https://deploy-preview-6274--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6274 (3743f2b) into v6 (cbb8fed) will increase coverage by 0.74%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #6274      +/-   ##
==========================================
+ Coverage   87.06%   87.81%   +0.74%     
==========================================
  Files         365      365              
  Lines       12579    12455     -124     
  Branches     3720     3669      -51     
==========================================
- Hits        10952    10937      -15     
+ Misses       1278     1158     -120     
- Partials      349      360      +11     

Flag	Coverage Δ
unittest	87.81% <ø> (+0.74%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/explicit-member-accessibility.ts	96.15% <0.00%> (-1.29%)	⬇️
...ckages/scope-manager/src/referencer/TypeVisitor.ts	97.97% <0.00%> (-1.02%)	⬇️
...ackages/scope-manager/src/referencer/Referencer.ts	95.49% <0.00%> (-0.43%)	⬇️
packages/eslint-plugin/src/rules/indent.ts	92.85% <0.00%> (ø)
...ages/eslint-plugin/src/rules/unified-signatures.ts	92.10% <0.00%> (ø)
.../eslint-plugin/src/rules/no-useless-constructor.ts	94.73% <0.00%> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts	92.06% <0.00%> (ø)
...kages/scope-manager/src/referencer/ClassVisitor.ts	93.44% <0.00%> (+0.70%)	⬆️
packages/typescript-estree/src/convert.ts	31.86% <0.00%> (+3.66%)	⬆️