Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): remove false from optional AST boolean properties #6273

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 24, 2022

PR Checklist

Overview

Switches most ?: boolean and : boolean properties to ?: true in ast-spec. Updates convert.ts accordingly to only assign those properties if they're true.

Does not update snapshots that need manual touchups, pending resolution of whether to use this or #6274.

@nx-cloud
Copy link

nx-cloud bot commented Dec 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8a73e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx run-many --target=build --all --parallel --exclude website --exclude website

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 24, 2022

Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit c8a73e4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63a6953bde76d5000856f058

@JoshuaKGoldberg
Copy link
Member Author

Going with #6274 per #5020 (comment).

@JoshuaKGoldberg JoshuaKGoldberg deleted the boolean-optional-remove-false branch January 20, 2023 00:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AST standardisation: remove undefined/optional from node properties unless it really makes sense
1 participant