chore: collapse generated snapshots in PR view by default

[Josh-Cena]

PR Checklist

• Addresses an existing open issue: fixes #000
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Per discussion with @JoshuaKGoldberg. This makes snapshots collapsed just like yarn.lock changes.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ef78d16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test eslint-plugin --coverage=false
• Node 14 - nx test parser --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test scope-manager --coverage=false
• Node 18 - nx test parser
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test typescript-estree
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test ast-spec
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test scope-manager
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	ef78d16
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63efd9e8323c120008d0bb7b
😎 Deploy Preview	https://deploy-preview-6485--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6485 (ef78d16) into main (c46c793) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6485      +/-   ##
==========================================
+ Coverage   90.64%   90.66%   +0.02%     
==========================================
  Files         373      374       +1     
  Lines       12751    12823      +72     
  Branches     3752     3777      +25     
==========================================
+ Hits        11558    11626      +68     
  Misses        853      853              
- Partials      340      344       +4     

Flag	Coverage Δ
unittest	90.66% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/explicit-function-return-type.ts	97.95% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-mixed-enums.ts	94.44% <0.00%> (ø)

[bradzacher]

Won't this remove the syntax highlighting in GH because you're losing the language attribute?

I don't know if they should be seen as generated - aside from codebase reactors, we'll really want to be reviewing all of our snapshots as code because they represent the AST output.

I do have an idea for adding snapshot testing to the rule tester as well, so that would be more snapshots to be reviewed.

[Josh-Cena]

Won't this remove the syntax highlighting in GH because you're losing the language attribute?

No it won't. linguist-language and linguist-generated are two orthogonal attributes. You can refer to https://github.com/github/linguist/blob/master/docs/overrides.md

I don't know if they should be seen as generated

You can still view the diff, just that they are collapsed by default. This prevents diffs like #6274 from being unviewable.

[JoshuaKGoldberg]

As long as syntax highlighting is preserved, I'm fine with auto-collapsing by default. I normally end up doing little console macros to collapse/expand everything anyway.